x/tools/cmd/goimports: lost line between package and import statements in output

[rsc]

$ cat x.go
package p // comment

import "math"

var _ = fmt.Printf
$ goimports x.go
package p // comment
import "fmt"

var _ = fmt.Printf
$ 

The blank line should not have been removed. This only happens when there is an end-of-line comment on the package statement.

/cc @bradfitz

[mvdan]

May be related to #26246. I assume that https://go-review.googlesource.com/c/tools/+/122538 won't fix this issue, as that CL only merges lines.

[fraenkel]

If you attempt to goimport the result

package p // comment
import "fmt"

var _ = fmt.Printf

no newline is inserted. I haven't found a commit that ever did insert the newline.

[gopherbot]

Change https://golang.org/cl/122736 mentions this issue: imports: fix lost line between package and import statement

[cuonglm]

I think this is expected behavior, according to this commit

But what happen when there're 2 or more comments:

package p // comment 1
          // comment 2

import "math"

var _ = fmt.Printf

What's designed output?