New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: list: incomplete error message "no Go files in" #26296

Open
alandonovan opened this Issue Jul 9, 2018 · 4 comments

Comments

Projects
None yet
5 participants
@alandonovan
Contributor

alandonovan commented Jul 9, 2018

$ cat a.go
package p

import "missing"

$ command go version
go version devel +4da84adc0c Mon Jul 9 19:35:21 2018 +0000 linux/amd64
$ command go list -export -e  a.go
go build missing: no Go files in 
command-line-arguments

I expect the fix is something like this:

--- a/src/cmd/go/internal/load/pkg.go
+++ b/src/cmd/go/internal/load/pkg.go
@@ -185,6 +185,9 @@ func (e *NoGoError) Error() string {
                // to appear at the end of error message.
                return "no non-test Go files in " + e.Package.Dir
        }
+       if e.Package.Dir == "" {
+               return "no directory for package " + e.Package.ImportPath
+       }
        return "no Go files in " + e.Package.Dir
 }
@odeke-em

This comment has been minimized.

Member

odeke-em commented Jul 31, 2018

How's it going @alandonovan? Might you have some bandwidth to get this in before the end of the week? If not, no worries :)

@mvdan

This comment has been minimized.

Member

mvdan commented Aug 1, 2018

I believe Alan is still on holiday :) Unless you meant to ping Russ? Either way, it will get some attention as it's milestoned for 1.11.

@rsc

This comment has been minimized.

Contributor

rsc commented Aug 10, 2018

The root cause here is #26909. Once that's fixed, the bogus NoGoError should not be generated at all anymore.

@rsc

This comment has been minimized.

Contributor

rsc commented Aug 17, 2018

Leaving for Go 1.12.

@rsc rsc modified the milestones: Go1.11, Go1.12 Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment