Skip to content

x/net/http2: fragile TestServer_Headers_HalfCloseRemote #26314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mikioh opened this issue Jul 10, 2018 · 2 comments
Closed

x/net/http2: fragile TestServer_Headers_HalfCloseRemote #26314

mikioh opened this issue Jul 10, 2018 · 2 comments
Labels
FrozenDueToAge
Milestone
Unplanned

Comments

@mikioh
Copy link
Contributor

mikioh commented Jul 10, 2018

See https://storage.googleapis.com/go-build-log/f9800a94/windows-386-2008_acdcfeaa.log.

ok  	golang.org/x/net/http/httpguts	0.060s
ok  	golang.org/x/net/http/httpproxy	1.217s
--- FAIL: TestServer_Headers_HalfCloseRemote (0.01s)
    server_test.go:3856: in handler, state is HalfClosedRemote; want Open
FAIL
FAIL	golang.org/x/net/http2	24.354s
?   	golang.org/x/net/http2/h2i	[no test files]

Also go test -run TestServer_Headers_HalfCloseRemote -count 100 can repro the issue.
@mikioh mikioh added this to the Unplanned milestone Jul 10, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/123037 mentions this issue: http2: fix race in TestServer_Headers_HalfCloseRemote

gopherbot pushed a commit to golang/net that referenced this issue Jul 10, 2018
@fraenkel @bradfitz
http2: fix race in TestServer_Headers_HalfCloseRemote
d5fb304 
Wait until stream is checked before sending data.

Updates golang/go#26314

Change-Id: If8a72d5e9ad313130043d0929dd741486aa2f0cd
Reviewed-on: https://go-review.googlesource.com/123037
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@mikioh
Copy link
Contributor Author

mikioh commented Nov 9, 2018

Looks like CL 123037 fixes this issue, closing.

@mikioh mikioh closed this as completed Nov 9, 2018
@golang golang locked and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
2 participants
@mikioh @gopherbot