Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: h2spec violation 6.10.1 #26324

Closed
fraenkel opened this issue Jul 11, 2018 · 2 comments
Closed

x/net/http2: h2spec violation 6.10.1 #26324

fraenkel opened this issue Jul 11, 2018 · 2 comments

Comments

@fraenkel
Copy link
Contributor

@fraenkel fraenkel commented Jul 11, 2018

$ ./h2spec -S -k -t -h 127.0.0.1 -p 8080 http2/6.10/1
Hypertext Transfer Protocol Version 2 (HTTP/2)
  6. Frame Definitions
    6.10. CONTINUATION
      × 1: Sends multiple CONTINUATION frames preceded by a HEADERS frame
        -> The endpoint must accept the frame.
           Expected: HEADERS Frame (stream_id:1)
             Actual: Connection closed
@fraenkel

This comment has been minimized.

Copy link
Contributor Author

@fraenkel fraenkel commented Jul 11, 2018

This one is valid.
There is no handling of a HEADER (END_HEADERS=false) + CONTINUATION.

@fraenkel

This comment has been minimized.

Copy link
Contributor Author

@fraenkel fraenkel commented Jul 12, 2018

My server had a MaxHeaderBytes set too low for this test. Once I increased it above the limit needed, the test passes.

@fraenkel fraenkel closed this Jul 12, 2018
@golang golang locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.