Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: h2spec violation generic 2/2 & 2/3 #26326

Closed
fraenkel opened this issue Jul 11, 2018 · 4 comments
Closed

x/net/http2: h2spec violation generic 2/2 & 2/3 #26326

fraenkel opened this issue Jul 11, 2018 · 4 comments

Comments

@fraenkel
Copy link
Contributor

@fraenkel fraenkel commented Jul 11, 2018

Generic tests for HTTP/2 server
  2. Streams and Multiplexing
    × 2: Sends a WINDOW_UPDATE frame on half-closed (remote) stream
      -> The endpoint MUST accept WINDOW_UPDATE frame.
         Expected: DATA frame
           Actual: HEADERS Frame (length:28, flags:0x05, stream_id:1)
    × 3: Sends a PRIORITY frame on half-closed (remote) stream
      -> The endpoint MUST accept PRIORITY frame.
         Expected: DATA frame
           Actual: HEADERS Frame (length:28, flags:0x05, stream_id:1)
@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Jul 11, 2018

Can we get repro details on these bugs too? What command did you run and against which code?

@fraenkel

This comment has been minimized.

Copy link
Contributor Author

@fraenkel fraenkel commented Jul 11, 2018

The command is $ ./h2spec -S -k -t -h 127.0.0.1 -p 8080 generic/2
I think its related to the "server" change I made in my set up which no longer sends any data back.
It expects a Data frame which assumes the server would send something back on a GET /.

If I change the server back to send back data, we pass. Which I assume is what this test assumes but the h2spec suite does not define how the Server should behave.

@fraenkel

This comment has been minimized.

Copy link
Contributor Author

@fraenkel fraenkel commented Jul 11, 2018

I would lean toward closing this since its working properly with a response.

@fraenkel

This comment has been minimized.

Copy link
Contributor Author

@fraenkel fraenkel commented Jul 13, 2018

Confirmed that the server is expected to send back some response therefore the test case does pass.

@fraenkel fraenkel closed this Jul 13, 2018
@golang golang locked and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.