Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: answer get questions raised in CL 122396 #26342

Closed
rsc opened this issue Jul 12, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@rsc
Copy link
Contributor

commented Jul 12, 2018

There are open comments in CL 122396 that need to be resolved in a future CL.

/cc @bcmills

@rsc rsc added this to the vgo milestone Jul 12, 2018

@rsc rsc self-assigned this Jul 12, 2018

@rsc rsc modified the milestones: vgo, Go1.11 Jul 12, 2018

@rsc rsc added the modules label Jul 12, 2018

@rsc rsc changed the title x/vgo: answer get questions raised in CL 122396 cmd/go: answer get questions raised in CL 122396 Jul 12, 2018

@bcmills bcmills added the NeedsFix label Jul 16, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Jul 18, 2018

Change https://golang.org/cl/124796 mentions this issue: cmd/go/internal/modget: fix get pkg@none

@gopherbot

This comment has been minimized.

Copy link

commented Jul 19, 2018

Change https://golang.org/cl/124856 mentions this issue: cmd/go: fix module get -u to avoid spurious new deps

gopherbot pushed a commit that referenced this issue Jul 19, 2018

cmd/go/internal/modget: fix get pkg@none
Now pkg@none actually removes the pkg instead of dying.

For #26342.

Change-Id: I9df7281ed8fd24480109b36f33a563f92e279244
Reviewed-on: https://go-review.googlesource.com/124796
Reviewed-by: Bryan C. Mills <bcmills@google.com>

@gopherbot gopherbot closed this in 0b23c88 Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.