New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: decide replace, exclude wildcard behavior #26344

Open
rsc opened this Issue Jul 12, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@rsc
Contributor

rsc commented Jul 12, 2018

In CL 122400 @bcmills pointed out that we haven't defined what

replace (
	example.com/foo v1.0.0 => elucidation.com/foo v1.1.0
	example.com/foo => elucidation.com/foo v1.2.0
)

means for example v1.0.0. Obviously it must mean you get elucidation v1.1.0 not v1.2.0. But that's not documented nor implemented.

Bryan also raised the question of whether to allow

exclude example.com/foo

to make it completely unavailable. Probably we should.

@rsc rsc modified the milestones: vgo, Go1.11 Jul 12, 2018

@rsc rsc added the modules label Jul 12, 2018

@rsc rsc changed the title from x/vgo: decide replace, exclude wildcard behavior to cmd/go: decide replace, exclude wildcard behavior Jul 12, 2018

@rsc

This comment has been minimized.

Contributor

rsc commented Aug 17, 2018

Will have to solve in Go 1.12. Until then, "don't do that."

@rsc rsc modified the milestones: Go1.11, Go1.12 Aug 17, 2018

@bcmills bcmills modified the milestones: Go1.12, Go1.13 Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment