New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: all.bash takes too long #26473

Open
rsc opened this Issue Jul 19, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@rsc
Contributor

rsc commented Jul 19, 2018

My target for all.bash is to keep it around 3-4 minutes. Usually when it gets to 5 minutes I spend some time trimming it back down. Maybe 3-4 minutes is no longer attainable, but right now we're at 7 minutes, which is much longer than I'd hope.

I filed a few bugs to try to help: #26469, #26472, #26470, #26471.

Speeding all.bash may also help speed the trybots, which also take longer than I'd hope.

@gopherbot

This comment has been minimized.

gopherbot commented Nov 4, 2018

Change https://golang.org/cl/147358 mentions this issue: strings: lower running time of TestCompareStrings

gopherbot pushed a commit that referenced this issue Nov 4, 2018

strings: lower running time of TestCompareStrings
At each comparison, we're making a copy of the whole string.
Instead, use unsafe to share the string backing store with a []byte.

It reduces the test time from ~4sec to ~1sec on my machine
(darwin/amd64).  Some builders were having much more trouble with this
test (>3min), it may help more there.

Fixes #26174
Fixes #28573
Fixes #26155
Update #26473

Change-Id: Id5856fd26faf6ff46e763a088f039230556a4116
Reviewed-on: https://go-review.googlesource.com/c/147358
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot

This comment has been minimized.

gopherbot commented Dec 6, 2018

Change https://golang.org/cl/152817 mentions this issue: cmd/cover: run tests in parallel, don't change source directory

gopherbot pushed a commit that referenced this issue Dec 6, 2018

cmd/cover: run tests in parallel, don't change source directory
This speeds up the cmd/cover testsuite by about 40% on my laptop.

Updates #26473
Updates #28386

Change-Id: I853b1b3b8c98dc89440f7b7bf5c0ade1d3d66802
Reviewed-on: https://go-review.googlesource.com/c/152817
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment