Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add Windows builder for long tests #26529

Closed
ysmolsky opened this issue Jul 22, 2018 · 6 comments
Assignees
Milestone

Comments

@ysmolsky
Copy link
Member

@ysmolsky ysmolsky commented Jul 22, 2018

We should run long tests on all major platforms, not only on Linux. Whenever test is removed from the short mode, it gets neglected because long tests are not run automatically.

As pointed out by @alexbrainman recently in #26469, Windows long tests are badly broken: #26469 (comment)

#26473 might move even more tests to the long mode.

@gopherbot gopherbot added this to the Unreleased milestone Jul 22, 2018
@gopherbot gopherbot added the Builders label Jul 22, 2018
@bradfitz

This comment has been minimized.

Copy link
Member

@bradfitz bradfitz commented Aug 3, 2018

Sure, this would be fine and easy.

Good warm-up project for @dmitshur.

@bradfitz

This comment has been minimized.

Copy link
Member

@bradfitz bradfitz commented Jan 18, 2019

Maybe @bcmills wants to do this.

@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Sep 16, 2019

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Oct 21, 2019

Change https://golang.org/cl/202479 mentions this issue: dashboard: add windows and 32-bit longtest builders

@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Oct 26, 2019

One failure down (#35117), another found (#35175). This this is gonna be passing someday, I just know it!

@bcmills

This comment has been minimized.

Copy link
Member

@bcmills bcmills commented Oct 29, 2019

The saga continues with #35236.

codebien added a commit to codebien/build that referenced this issue Nov 13, 2019
Fixes golang/go#29641
Fixes golang/go#26529

Change-Id: I5ab3aa443276ab36b866d7fabc1d78a82b34cb64
Reviewed-on: https://go-review.googlesource.com/c/build/+/202479
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.