Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/cmd/godoc: fix TestWeb failures for <1.11 releases #26531
I see failures across all platforms.
Mostly it is this line which is getting repeated in all the test logs-
Looks like a valid failure which needs to be fixed. Please feel free to correct me if I am wrong.
I don't believe so, x/tools/go/packages is a higher level abstraction that uses golang.org/x/tools/go/gcexportdata to load export data itself.
I think I have figured it out. It is this test which is actually failing in 1.10 and 1.9.
And that is due to @bradfitz's latest changes to show version info in godoc. It is checking for text which has only been added in 1.11. Hence those are failing for 1.10 and 1.9. I am going to repurpose this bug to fix this since I see a clear reason for the failure.
I don't see the gcimporter_test.go failures any more. It is just TestWeb failures now. We can create a new issue if we see that again.