Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/godoc: fix TestWeb failures for <1.11 releases #26531

Closed
agnivade opened this issue Jul 22, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@agnivade
Copy link
Member

commented Jul 22, 2018

https://build.golang.org/?repo=golang.org%2fx%2ftools.

I see failures across all platforms.

Mostly it is this line which is getting repeated in all the test logs-

 gcimporter_test.go:93: testPath(image): reading export data: /path/to/some_file.a: cannot import, possibly version skew (unknown export format version -1 ("<hex_escaped_text>")) - reinstall package

A couple of the failures -
https://build.golang.org/log/af9e4d76623dc0222c893aea9fb08594d936c271
https://build.golang.org/log/572376bd9dd8e6c81e37c95d587d030c25291b66

Looks like a valid failure which needs to be fixed. Please feel free to correct me if I am wrong.

@gopherbot gopherbot added this to the Unreleased milestone Jul 22, 2018

@mvdan

This comment has been minimized.

Copy link
Member

commented Jul 22, 2018

Perhaps related to this earlier error?

# golang.org/x/tools/godoc
/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/gopath/src/golang.org/x/tools/godoc/template.go:93: missing ... in args forwarded to printf-like function
@agnivade

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2018

Perhaps, although that was changed on 13th June. golang/tools@02fcd6a. I am unable to see all results from the release-branch.go.1.10 in the build dashboard UI, which might shed more light.

@bcmills

This comment has been minimized.

Copy link
Member

commented Jul 23, 2018

@ianthehat, is this related to the work on x/tools/go/packages?

@ianthehat

This comment has been minimized.

Copy link

commented Jul 23, 2018

I don't believe so, x/tools/go/packages is a higher level abstraction that uses golang.org/x/tools/go/gcexportdata to load export data itself.
The version skew message implies that the compiler and the gcimporter disagreed about the format of the export data, I know it changed in 1.11 but I thought all the code to do with that had been stable for a while now, and was selected by build tag.

@agnivade

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2018

I think I have figured it out. It is this test which is actually failing in 1.10 and 1.9.

TestWeb
FAIL	golang.org/x/tools/cmd/godoc	10.326s

And that is due to @bradfitz's latest changes to show version info in godoc. It is checking for text which has only been added in 1.11. Hence those are failing for 1.10 and 1.9. I am going to repurpose this bug to fix this since I see a clear reason for the failure.

I don't see the gcimporter_test.go failures any more. It is just TestWeb failures now. We can create a new issue if we see that again.

@agnivade agnivade changed the title x/tools: build dashboard is red x/tools/cmd/godoc: fix TestWeb failures for <1.11 releases Jul 25, 2018

@agnivade agnivade self-assigned this Jul 25, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Jul 25, 2018

Change https://golang.org/cl/125755 mentions this issue: cmd/godoc: fix TestWeb for versions < 1.11

@gopherbot

This comment has been minimized.

Copy link

commented Jul 25, 2018

Change https://golang.org/cl/125816 mentions this issue: godoc: fix tests on Go 1.9

gopherbot pushed a commit to golang/tools that referenced this issue Jul 25, 2018

godoc: fix tests on Go 1.9
Updates golang/go#11811
Updates golang/go#26531

Change-Id: I9cc7daf551b76c3f06b9dd827c5733513c06895e
Reviewed-on: https://go-review.googlesource.com/125816
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Agniva De Sarker <agniva.quicksilver@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.