Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestWorkParallel failures on some builders #26642

Closed
mvdan opened this issue Jul 27, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@mvdan
Copy link
Member

commented Jul 27, 2018

Such as darwin-amd64-10_11 https://build.golang.org/log/fb2df544c7d261e5527d9a92935d559f87f83e79:

--- FAIL: TestWorkParallel (0.41s)
panic: par.Work.Do: already called Do [recovered]
	panic: par.Work.Do: already called Do

goroutine 106 [running]:
testing.tRunner.func1(0xc00009a400)
	/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/go/src/testing/testing.go:792 +0x387
panic(0x1109520, 0x1157890)
	/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/go/src/runtime/panic.go:513 +0x1b9
cmd/go/internal/par.(*Work).Do(0xc000094200, 0x64, 0xc000244000)
	/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/go/src/cmd/go/internal/par/work.go:59 +0x108
cmd/go/internal/par.TestWorkParallel(0xc00009a400)
	/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/go/src/cmd/go/internal/par/work_test.go:44 +0x124
testing.tRunner(0xc00009a400, 0x11427a0)
	/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/go/src/testing/testing.go:827 +0xbf
created by testing.(*T).Run
	/var/folders/dx/k53rs1s93538b4x20g46cj_w0000gn/T/workdir/go/src/testing/testing.go:878 +0x353

I think I know the reason, and will send a CL soon. cc @rsc

@mvdan mvdan added this to the Go1.11 milestone Jul 27, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Jul 27, 2018

Change https://golang.org/cl/126355 mentions this issue: cmd/go/internal/par: fix TestWorkParallel retries

@gopherbot gopherbot closed this in b39fb9e Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.