x/build: add a builder with git 2.7.4 to catch cmd/go regressions #26653
Comments
Git 2.7.4 is notable(?) because it is the stock version in Ubuntu 16.04 LTS.¹ However, it's not obvious to me why we should draw the line at Ubuntu 16.04: the Ubuntu project claims to still support 14.04.5 LTS,² and the current release is 18.04 LTS. (Ubuntu 18.04 LTS provides git 2.17,³ which is much more recent.) I don't actually see a minimum Ubuntu or Git version listed on https://tip.golang.org/doc/install. Perhaps we should add one. (CC: @rsc @rogpeppe @bradfitz @myitcv) ¹https://packages.ubuntu.com/xenial/vcs/git |
I think thats a wonderful idea! |
Whether Ubuntu 14.04 is a sufficiently broad baseline for this sort of analysis I'm not 100% sure (it's pretty good on the basis it's used by Travis); it ships |
My development VM was Debian Jessie for the longest time and its old git (https://packages.debian.org/jessie/git-core ... 2.1.4) was what finally forced me to update to stretch. |
Note also #26594 (comment), which suggests we might also need to add tests for different remote types. |
(Note that Ubuntu 14.04.6 LTS reached the end of its Ubuntu “standard support” lifetime in April 2019.) |
What did you expect to see?
The bug fix for breaking go on Ubuntu 16 would have a test or ci change to prevent a similar error in the future.
What did you see instead?
A code change with no test change.
Context
#26501 (comment)
The text was updated successfully, but these errors were encountered: