New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: add a builder with git 2.7.4 to catch cmd/go regressions #26653

Open
trashhalo opened this Issue Jul 28, 2018 · 5 comments

Comments

Projects
None yet
7 participants
@trashhalo

trashhalo commented Jul 28, 2018

What did you expect to see?

The bug fix for breaking go on Ubuntu 16 would have a test or ci change to prevent a similar error in the future.

What did you see instead?

A code change with no test change.

Context

#26501 (comment)

@ysmolsky ysmolsky added the Testing label Jul 28, 2018

@oiooj oiooj added the modules label Jul 28, 2018

@bcmills bcmills added the Builders label Aug 1, 2018

@bcmills bcmills changed the title from cmd/go: add test to ensure compatibility with git 2.7.4 to x/build: add a builder with git 2.7.4 to catch cmd/go regressions Aug 1, 2018

@gopherbot gopherbot added this to the Unreleased milestone Aug 1, 2018

@bcmills

This comment has been minimized.

Member

bcmills commented Aug 1, 2018

Git 2.7.4 is notable(?) because it is the stock version in Ubuntu 16.04 LTS.¹

However, it's not obvious to me why we should draw the line at Ubuntu 16.04: the Ubuntu project claims to still support 14.04.5 LTS,² and the current release is 18.04 LTS. (Ubuntu 18.04 LTS provides git 2.17,³ which is much more recent.)

I don't actually see a minimum Ubuntu or Git version listed on https://tip.golang.org/doc/install. Perhaps we should add one.

(CC: @rsc @rogpeppe @bradfitz @myitcv)

¹https://packages.ubuntu.com/xenial/vcs/git
²https://wiki.ubuntu.com/Releases
³https://packages.ubuntu.com/bionic/vcs/git

@trashhalo

This comment has been minimized.

trashhalo commented Aug 1, 2018

I don't actually see a minimum Ubuntu or Git version listed on https://tip.golang.org/doc/install. Perhaps we should add one.

I think thats a wonderful idea!

@myitcv

This comment has been minimized.

Member

myitcv commented Aug 1, 2018

Whether Ubuntu 14.04 is a sufficiently broad baseline for this sort of analysis I'm not 100% sure (it's pretty good on the basis it's used by Travis); it ships git version 1.9.1

@bradfitz

This comment has been minimized.

Member

bradfitz commented Aug 1, 2018

My development VM was Debian Jessie for the longest time and its old git (https://packages.debian.org/jessie/git-core ... 2.1.4) was what finally forced me to update to stretch.

@myitcv

This comment has been minimized.

Member

myitcv commented Aug 8, 2018

Note also #26594 (comment), which suggests we might also need to add tests for different remote types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment