Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: document why go get module@none is interesting #26684

Closed
nhooyr opened this Issue Jul 30, 2018 · 4 comments

Comments

Projects
None yet
5 participants
@nhooyr
Copy link
Contributor

nhooyr commented Jul 30, 2018

Could not find any docs regarding this. What makes @none useful? Why would you want to just remove a package? Wouldn't your code still depend on it? Or is this only after you remove the usage of the package? And if so, wouldn't Go do this automatically on the next build?

@nhooyr

This comment has been minimized.

Copy link
Contributor Author

nhooyr commented Jul 30, 2018

To be clear, this is a docs issue.

@bcmills bcmills modified the milestones: Go1.12, Go1.11 Aug 1, 2018

@rsc rsc changed the title cmd/go: when would you want to use go get module@none? cmd/go: document why go get module@none is interesting Aug 10, 2018

@rsc rsc modified the milestones: Go1.11, Go1.12 Aug 17, 2018

@rsc

This comment has been minimized.

Copy link
Contributor

rsc commented Oct 25, 2018

Current text:

If a module under consideration is already a dependency of the current
development module, then get will update the required version.
Specifying a version earlier than the current required version is valid and
downgrades the dependency. The version suffix @none indicates that the
dependency should be removed entirely.

We could add to the last sentence:

... removed entirely, downgrading or removing modules depending on it as needed.

@nhooyr

This comment has been minimized.

Copy link
Contributor Author

nhooyr commented Feb 3, 2019

That'd be perfect.

@ALTree ALTree added NeedsFix and removed NeedsInvestigation labels Feb 4, 2019

@gopherbot

This comment has been minimized.

Copy link

gopherbot commented Feb 4, 2019

Change https://golang.org/cl/161037 mentions this issue: cmd/go: clarify @none effect on dependants modules

@gopherbot gopherbot closed this in b5be877 Feb 4, 2019

nebulabox added a commit to nebulabox/go that referenced this issue Feb 18, 2019

cmd/go: clarify @none effect on dependants modules
Expand modules documentation to clarify why @none is useful. The
wording is the one suggested by rsc on the issue.

Fixes golang#26684

Change-Id: I76dc4ff87e50f1dd8536fd9ac1fd938adb29bee3
Reviewed-on: https://go-review.googlesource.com/c/161037
Reviewed-by: Bryan C. Mills <bcmills@google.com>

nebulabox added a commit to nebulabox/go that referenced this issue Feb 20, 2019

cmd/go: clarify @none effect on dependants modules
Expand modules documentation to clarify why @none is useful. The
wording is the one suggested by rsc on the issue.

Fixes golang#26684

Change-Id: I76dc4ff87e50f1dd8536fd9ac1fd938adb29bee3
Reviewed-on: https://go-review.googlesource.com/c/161037
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.