Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: define SO_REUSEPORT #26771

Closed
chantra opened this issue Aug 2, 2018 · 4 comments
Closed

syscall: define SO_REUSEPORT #26771

chantra opened this issue Aug 2, 2018 · 4 comments
Labels
FeatureRequest FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone

Comments

@chantra
Copy link

chantra commented Aug 2, 2018

What version of Go are you using (go version)?

1.11beta2

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/chantra/local/go"
GORACE=""
GOROOT="/usr/lib/golang"
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build452115149=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?

Using https://gist.github.com/chantra/7783d1fe5e6e859c066aa7dcdcac5e87

On my environment:

$ go1.11beta2 run /tmp/a.go
# command-line-arguments
/tmp/a.go:12:79: undefined: syscall.SO_REUSEPORT

It works on the nacl platform: https://play.golang.org/p/BxiHNMO-4Z9

What did you expect to see?

I would expect syscall.SO_REUSEPORT to be defined. Even more so that with the apparition of the net.Listenconfig interface in go1.11, it will now be possible to set SO_REUSEPORT on sockets.
The work around in chantra/dns@e80149d is to hardcode the value for Linux amd64 platform (e.g 0xF)

$ grep SO_REUSEPORT /usr/include/ -r
/usr/include/asm-generic/socket.h:#define SO_REUSEPORT  15

What did you see instead?

$ go1.11beta2 run /tmp/a.go
# command-line-arguments
/tmp/a.go:12:79: undefined: syscall.SO_REUSEPORT
@bcmills
Copy link
Member

bcmills commented Aug 2, 2018

The syscall package is frozen.

Is there a reason you can't use the SO_REUSEPORT from golang.org/x/sys/unix?

@bcmills bcmills changed the title [go1.11] define syscall.SO_REUSEPORT syscall: define SO_REUSEPORT Aug 2, 2018
@bcmills bcmills added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 2, 2018
@bcmills bcmills added this to the Unplanned milestone Aug 2, 2018
@chantra
Copy link
Author

chantra commented Aug 2, 2018

@bcmills sure I can use golang.org/x/sys/unix but given that SO_REUSEADDR & co were under syscall, I would have expected SO_REUSEPORT to be (eventually) under the same namespace.

@bcmills
Copy link
Member

bcmills commented Aug 2, 2018

The syscall package is frozen. We generally only add to it if the additions are needed elsewhere in the runtime or standard library.

@bcmills bcmills added NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. labels Aug 2, 2018
@bcmills bcmills closed this as completed Aug 2, 2018
@chantra
Copy link
Author

chantra commented Aug 3, 2018

The syscall package is frozen. We generally only add to it if the additions are needed elsewhere in the runtime or standard library.

oh.... as in frozen for ever.... I thought you meant for 1.11 release originally.

@golang golang locked and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FeatureRequest FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Development

No branches or pull requests

3 participants