Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: stop testing dev.boringcrypto branch on so many builders #26791

Closed
bradfitz opened this issue Aug 3, 2018 · 8 comments
Closed

x/build: stop testing dev.boringcrypto branch on so many builders #26791

bradfitz opened this issue Aug 3, 2018 · 8 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Aug 3, 2018

We really only care about testing the dev.boringcrypto branch on linux/amd64, really. Right now we're testing it on everything.

@bradfitz bradfitz added the NeedsFix label Aug 3, 2018
@gopherbot gopherbot added this to the Unreleased milestone Aug 3, 2018
@gopherbot gopherbot added the Builders label Aug 3, 2018
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Aug 3, 2018

Probably in cmd/coordinator's skipBranchForBuilder and/or x/build/dashboard/builders.go.

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Aug 3, 2018

I suggest testing it on at least one other builder, because the fallbacks are supposed to keep working.

@dmitshur dmitshur added NeedsDecision and removed NeedsFix labels Nov 14, 2018
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 14, 2018

Testing on at least one other builder in addition to linux/amd64 itself sounds reasonable. Which one (or ones)?

Some possibilities:

@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Nov 14, 2018

If we need to pick another non-linux/amd64 builder, at least pick a GCE-based one where we have lots of capacity. So not Darwin, and not arm. windows/386 gets a different GOOS and a different GOARCH with one new builder. Or freebsd/386, but freebsd and linux might be too similar.

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 14, 2018

Change https://golang.org/cl/149606 mentions this issue: dashboard: add FirstClass field to BuildConfig

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Nov 14, 2018

Sounds like the decision is to use windows/386. I'll proceed with that for now, but happy to change it if there's further feedback.

@dmitshur dmitshur added NeedsFix and removed NeedsDecision labels Nov 14, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 15, 2018

Change https://golang.org/cl/149739 mentions this issue: dashboard: skip dev.boringcrypto branches on most builders

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 15, 2018

Change https://golang.org/cl/149738 mentions this issue: cmd/coordinator: move skip branch policy into dashboard

gopherbot pushed a commit to golang/build that referenced this issue Nov 15, 2018
This change takes care of a TODO comment. It makes the builder
configuration more centralized and contained in the dashboard
package.

Invert it for consistency with BuildConfig.BuildRepo method.

Updates golang/go#26791

Change-Id: I46368adadb85f2ec730da4fc0abe5fd6a112a7c7
Reviewed-on: https://go-review.googlesource.com/c/149738
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@golang golang locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.