Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: add author to issue notification comments #26816

Open
josharian opened this issue Aug 5, 2018 · 4 comments · May be fixed by golang/build#10 or golang/build#20

Comments

@josharian
Copy link
Contributor

commented Aug 5, 2018

gopherbot generates the "CL mentions this issue" issue comments:

https://github.com/golang/build/blob/4639cd3919e4243a672a11a56543004bf1778326/cmd/gopherbot/gopherbot.go#L811

It currently includes a link to the CL and the CL title. It'd be nice if it also included the CL author's name or handle. Maybe: "Change <link> by <author> mentions this issue: <title>".

@iamoryanmoshe

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2018

I'll take a crack at it

@gopherbot

This comment has been minimized.

Copy link

commented Aug 6, 2018

Change https://golang.org/cl/127930 mentions this issue: cmd/gopherbot: change issue notification comment to include author name

@iamoryanmoshe

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2018

Or not

@gopherbot

This comment has been minimized.

Copy link

commented Jun 12, 2019

Change https://golang.org/cl/181977 mentions this issue: cmd/gopherbot: add the author of the change to the notification on github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.