Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: modules: git fatal: unrecognized argument: --no-show-signature #26844

Closed
lelvisl opened this issue Aug 7, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@lelvisl
Copy link

commented Aug 7, 2018

git.go:381

out, err := Run(r.dir, "git", "log", "-n1", "--format=format:%H %ct %D", "--no-show-signature", rev)

But some versions of git (2.4.0 and lower ) can't recognise argument --no-show-signature
This change was added in
golang/vgo@2093985#diff-67818c73dedcc22dbe195cd3afc253d8R381

Is it so necessary? Can it be disabled/removed?

@zegl

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2018

@lelvisl Which version of go are you using? This bug should be fixed in go1.11beta3: #26501

@lelvisl

This comment has been minimized.

Copy link
Author

commented Aug 7, 2018

@zegl 1.10.3
In fixed in go modules, not in vgo. Ok, thx!
Will it be fixed in vgo?

@myitcv

This comment has been minimized.

Copy link
Member

commented Aug 7, 2018

@lelvisl

Will it be fixed in vgo?

Yes: https://groups.google.com/d/msg/golang-dev/BizWQk-hfw4/JdhnnJdJDAAJ

Specifically: https://go-review.googlesource.com/c/vgo/+/127956

I'll close this because there is nothing to do here.

@myitcv myitcv closed this Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.