Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: golang.org/design should redirect to Gerrit, not GitHub #26871

Closed
rsc opened this issue Aug 8, 2018 · 1 comment
Milestone

Comments

@rsc
Copy link
Contributor

@rsc rsc commented Aug 8, 2018

https://golang.org/design/DOC redirects to
https://github.com/golang/proposal/blob/master/design/DOC.md.

We should redirect it instead to
https://go.googlesource.com/proposal/+/master/design/DOC.md.

The Gerrit Markdown renderer appears to be just as capable as GitHub's,
the Gerrit repo is the actual source of truth,
changes made to the design repo are visible immediately in the Gerrit renderer instead of having to wait for GitHub mirroring,
and most important of all the Gerrit rendering is a well-formatted, printable document instead of just a web page.

Compare:

https://github.com/golang/proposal/blob/master/design/25719-go15vendor.md
https://go.googlesource.com/proposal/+/master/design/25719-go15vendor.md

/cc @andybons

@rsc rsc added this to the Unreleased milestone Aug 8, 2018
@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Aug 8, 2018

Change https://golang.org/cl/128596 mentions this issue: godoc/redirect: redirect design docs to Gerrit, not GitHub

@golang golang locked and limited conversation to collaborators Aug 8, 2019
Bogdan-D pushed a commit to Bogdan-D/godocx that referenced this issue Nov 13, 2019
Gerrit's rendering is cleaner and Gerrit is the source of truth anyway.

Fixes golang/go#26871.

Change-Id: I0bf69d174662c7acc083b03b009bac92f781a17c
Reviewed-on: https://go-review.googlesource.com/128596
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.