Skip to content

/go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: 25% of time used in map insertions #26877

Open
griesemer opened this issue Aug 8, 2018 · 1 comment

Comments

Assignees

@griesemer griesemer

Labels
Performance
Projects
None yet
Milestone
  Unplanned
2 participants
@griesemer @navytux
@griesemer
Copy link
Contributor

commented Aug 8, 2018

Reminder issue to investigate.

From an e-mail by @alandonovan:

FYI: a profile of a go/types app showed nodeSet.add's use of map insertions accounts for 25% of all typechecking time. Something to look at on a rainy day (if you find yourself in SF this summer).

@griesemer griesemer added the Performance label Aug 8, 2018

@griesemer griesemer added this to the Unplanned milestone Aug 8, 2018

@griesemer griesemer self-assigned this Aug 8, 2018

@navytux

This comment has been minimized.

Sign in to view
Copy link
Contributor

commented Aug 28, 2018

Related issue about map operations being slow: #19495.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.