Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: convert replacements from vendor.conf #26892

Closed
RalphCorderoy opened this issue Aug 9, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@RalphCorderoy
Copy link

commented Aug 9, 2018

Viewing tip's source, https://github.com/golang/go/blob/master/src/cmd/go/internal/modconv/vconf.go only uses the first two fields of vendor.conf's line and ignores the rest, but https://github.com/docker/distribution/blob/master/vendor.conf#L50 specifies a forked repo with

rsc.io/letsencrypt e770c10b0f1a64775ae91d240407ce00d1a5bdeb https://github.com/dmcgowan/letsencrypt.git

so errors like

go: converting vendor.conf: stat rsc.io/letsencrypt@e770c10b0f1a64775ae91d240407ce00d1a5bdeb: unknown revision e770c10b0f1a64775ae91d240407ce00d1a5bdeb

result because e77 is in dmcgowan, not rsc.io.

@bcmills

This comment has been minimized.

Copy link
Member

commented Aug 9, 2018

See also #25556.

CC: @oiooj

@bcmills bcmills changed the title cmd/go: go mod converting vendor.conf ignores pertinent third field cmd/go: convert replacements from vendor.conf Aug 9, 2018

@bcmills bcmills added the modules label Aug 9, 2018

@bcmills bcmills added this to the Go1.12 milestone Aug 9, 2018

@rsc

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2018

Duplicate of #25556, which is meant to cover all the possible systems.

@rsc rsc closed this Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.