Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/maintner: negative byte downloads #26922

Closed
dmitshur opened this issue Aug 10, 2018 · 2 comments
Closed

x/build/maintner: negative byte downloads #26922

dmitshur opened this issue Aug 10, 2018 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@dmitshur
Copy link
Contributor

I've seen negative byte downloads in the logs of programs that use the maintner client. E.g.:

2018/08/08 14:01:07 Downloading -6670 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 14:09:37 Downloading -17228 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 14:19:31 Downloading -38666 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 14:27:18 Downloading -10229 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 15:12:23 Downloading -13379 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 15:17:38 Downloading -16171 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 15:24:00 Downloading -28018 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 15:30:51 Downloading -28436 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 16:17:27 Downloading -811 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 16:17:43 Downloading -495 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 16:55:01 Downloading -20370 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:10:43 Downloading -4056 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:10:58 Downloading -323 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:11:13 Downloading -323 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:11:28 Downloading -323 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:17:46 Downloading -33025 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:18:01 Downloading -209 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:18:16 Downloading -209 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:18:31 Downloading -209 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:18:47 Downloading -209 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:19:02 Downloading -209 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:19:17 Downloading -209 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:19:32 Downloading -209 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 17:55:33 Downloading -288 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 18:33:27 Downloading -521 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 18:33:42 Downloading -275 bytes of https://maintner.golang.org/logs/38 ...
2018/08/08 18:33:57 Downloading -275 bytes of https://maintner.golang.org/logs/38 ...

That doesn't make sense and shouldn't be possible.

I think it happens near/during net split (maintner.ErrSplit) situations only, so it's not very critical, but would be nice to understand why it happens and fix.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 10, 2018
@gopherbot gopherbot added this to the Unreleased milestone Aug 10, 2018
@dmitshur dmitshur changed the title x/build/maintner: negative byte downloads shouldn't happen x/build/maintner: negative byte downloads Aug 10, 2018
@gopherbot
Copy link

Change https://go.dev/cl/414434 mentions this issue: maintner: don't try to download negative bytes

@dmitshur
Copy link
Contributor Author

The downloading code was just missing the case for where the client had more bytes than server (due to server restarting with some uncommitted transactions).

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 27, 2022
@dmitshur dmitshur added this to In Progress in Go Release Team Jul 7, 2022
@dmitshur dmitshur moved this from In Progress to Done in Go Release Team Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

2 participants