Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: allow configuring read timeout of response body with transport #26941

Closed
nhooyr opened this issue Aug 12, 2018 · 3 comments
Closed

net/http: allow configuring read timeout of response body with transport #26941

nhooyr opened this issue Aug 12, 2018 · 3 comments
Labels
FrozenDueToAge

Comments

@nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Aug 12, 2018 •
edited

I'd like ResponseHeaderTimeout but for the response body.
@nhooyr nhooyr changed the title net/http/httputil: Allow configuring read timeout on response body net/http/httputil: allow configuring read timeout of response body with reverse proxy Aug 12, 2018
@meirf

This comment has been minimized.

Sign in to view
Copy link
Contributor

@meirf meirf commented Aug 12, 2018

I commented on your other issue here: #26942 (comment). If you have the same response, let's just keep the convo there. Otherwise, could be better to have separate conversations.
@nhooyr

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@nhooyr nhooyr commented Aug 12, 2018

Actually this should go into http.Transport.
@nhooyr nhooyr changed the title net/http/httputil: allow configuring read timeout of response body with reverse proxy net/http: allow configuring read timeout of response body with transport Aug 12, 2018
@nhooyr

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

@nhooyr nhooyr commented Aug 12, 2018

Just realized I can just cancel the request context to make this work. All is good.
@nhooyr nhooyr closed this Aug 12, 2018
@nhooyr nhooyr mentioned this issue Aug 12, 2018
Closed
@golang golang locked and limited conversation to collaborators Aug 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@nhooyr @meirf @gopherbot
You can’t perform that action at this time.