Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: Allow configuring write timeout of header/body on transport #26942

Closed
nhooyr opened this issue Aug 12, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@nhooyr
Copy link
Contributor

commented Aug 12, 2018

Not sure how important this is but given *http.Server has fields for this, maybe *httputil.ReverseProxy should as well.

@meirf

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2018

Have you considered setting whatever you want on http.Server and then setting the reverse proxy as the Server's Handler? Do you see any concerns with that?

@nhooyr nhooyr changed the title net/http/httputil: Allow configuring write timeout of header/body on reverse proxy net/http: Allow configuring write timeout of header/body on transport Aug 12, 2018

@nhooyr

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2018

Just realized I can just cancel the request context to make this work. All is good.

@nhooyr nhooyr closed this Aug 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.