Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestVariousDeadlines failing on plan9/386 builder #26945

Open
0intro opened this issue Aug 12, 2018 · 5 comments
Open

net: TestVariousDeadlines failing on plan9/386 builder #26945

0intro opened this issue Aug 12, 2018 · 5 comments
Assignees
@dmitshur @0intro
Labels
Builders OS-Plan9
Milestone
Unplanned

Comments

@0intro
Copy link
Member

@0intro 0intro commented Aug 12, 2018

TestVariousDeadlines is regularly failing on the plan9/386 builder.

--- FAIL: TestVariousDeadlines (6.21s)
    timeout_test.go:880: 1ns run 1/1
    timeout_test.go:905: for 1ns run 1/1, good client timeout after 81.296µs, reading 0 bytes
    timeout_test.go:915: for 1ns run 1/1, server in 3.50244ms wrote 458752: readfrom tcp 127.0.0.1:43229->127.0.0.1:62762: write tcp 127.0.0.1:43229->127.0.0.1:62762: write /net/tcp/166/data: Hangup
    timeout_test.go:880: 2ns run 1/1
    timeout_test.go:905: for 2ns run 1/1, good client timeout after 56.991µs, reading 0 bytes
    timeout_test.go:915: for 2ns run 1/1, server in 7.46919ms wrote 1048576: readfrom tcp 127.0.0.1:43229->127.0.0.1:38454: write tcp 127.0.0.1:43229->127.0.0.1:38454: write /net/tcp/167/data: Hangup
    timeout_test.go:880: 5ns run 1/1
    timeout_test.go:905: for 5ns run 1/1, good client timeout after 58.667µs, reading 0 bytes
    timeout_test.go:915: for 5ns run 1/1, server in 7.167473ms wrote 1048576: readfrom tcp 127.0.0.1:43229->127.0.0.1:59766: write tcp 127.0.0.1:43229->127.0.0.1:59766: write /net/tcp/168/data: Hangup
    timeout_test.go:880: 50ns run 1/1
    timeout_test.go:905: for 50ns run 1/1, good client timeout after 56.153µs, reading 0 bytes
    timeout_test.go:915: for 50ns run 1/1, server in 4.392508ms wrote 524288: readfrom tcp 127.0.0.1:43229->127.0.0.1:62830: write tcp 127.0.0.1:43229->127.0.0.1:62830: write /net/tcp/169/data: Hangup
    timeout_test.go:880: 100ns run 1/1
    timeout_test.go:905: for 100ns run 1/1, good client timeout after 56.153µs, reading 0 bytes
    timeout_test.go:915: for 100ns run 1/1, server in 4.517385ms wrote 622592: readfrom tcp 127.0.0.1:43229->127.0.0.1:50076: write tcp 127.0.0.1:43229->127.0.0.1:50076: write /net/tcp/170/data: Hangup
    timeout_test.go:880: 200ns run 1/1
    timeout_test.go:905: for 200ns run 1/1, good client timeout after 57.829µs, reading 0 bytes
    timeout_test.go:915: for 200ns run 1/1, server in 3.538478ms wrote 458752: readfrom tcp 127.0.0.1:43229->127.0.0.1:44015: write tcp 127.0.0.1:43229->127.0.0.1:44015: write /net/tcp/171/data: Hangup
    timeout_test.go:880: 500ns run 1/1
    timeout_test.go:905: for 500ns run 1/1, good client timeout after 64.534µs, reading 0 bytes
    timeout_test.go:915: for 500ns run 1/1, server in 3.929036ms wrote 524288: readfrom tcp 127.0.0.1:43229->127.0.0.1:50845: write tcp 127.0.0.1:43229->127.0.0.1:50845: write /net/tcp/172/data: Hangup
    timeout_test.go:880: 750ns run 1/1
    timeout_test.go:905: for 750ns run 1/1, good client timeout after 56.991µs, reading 0 bytes
    timeout_test.go:915: for 750ns run 1/1, server in 7.222787ms wrote 1048576: readfrom tcp 127.0.0.1:43229->127.0.0.1:54489: write tcp 127.0.0.1:43229->127.0.0.1:54489: write /net/tcp/173/data: Hangup
    timeout_test.go:880: 1µs run 1/1
    timeout_test.go:905: for 1µs run 1/1, good client timeout after 56.991µs, reading 0 bytes
    timeout_test.go:915: for 1µs run 1/1, server in 4.337192ms wrote 557056: readfrom tcp 127.0.0.1:43229->127.0.0.1:55578: write tcp 127.0.0.1:43229->127.0.0.1:55578: write /net/tcp/174/data: Hangup
    timeout_test.go:880: 5µs run 1/1
    timeout_test.go:905: for 5µs run 1/1, good client timeout after 59.506µs, reading 0 bytes
    timeout_test.go:915: for 5µs run 1/1, server in 3.603013ms wrote 458752: readfrom tcp 127.0.0.1:43229->127.0.0.1:35569: write tcp 127.0.0.1:43229->127.0.0.1:35569: write /net/tcp/175/data: Hangup
    timeout_test.go:880: 25µs run 1/1
    timeout_test.go:905: for 25µs run 1/1, good client timeout after 57.829µs, reading 0 bytes
    timeout_test.go:915: for 25µs run 1/1, server in 2.280483ms wrote 294912: readfrom tcp 127.0.0.1:43229->127.0.0.1:58149: write tcp 127.0.0.1:43229->127.0.0.1:58149: write /net/tcp/176/data: Hangup
    timeout_test.go:880: 250µs run 1/1
    timeout_test.go:910: for 250µs run 1/1, timeout (5s) waiting for client to timeout (250µs) reading
FAIL
FAIL	net	30.849s

See https://build.golang.org/log/4b9709667343395dcd2d93c1447461e4fb807a33

This is related to issue #19519.

@millerresearch
@0intro 0intro added this to the Unplanned milestone Aug 12, 2018
@0intro 0intro self-assigned this Aug 12, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 12, 2018

Change https://golang.org/cl/129098 mentions this issue: env: disable aux/timesync in Plan 9 image
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 21, 2018

Change https://golang.org/cl/130137 mentions this issue: dashboard: bump plan9-386-v5 image to v6
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 21, 2018 •
edited

Re-opening so we can confirm that the flakiness gets fixed after the change is deployed.

Edit: The change from CL 129098 is deployed now.
@dmitshur dmitshur reopened this Aug 21, 2018
gopherbot pushed a commit to golang/build that referenced this issue Aug 21, 2018
@dmitshur
dashboard: bump plan9-386-v5 image to v6
08651b1 
plan9-386-v6 is a new plan9-386 image built with the change
done in CL 129098.

I tested it with cmd/debugnewvm on latest Go master commit,
and all stdlib tests passed, including TestVariousDeadlines.
(cmd/... tests didn't finish in time before cmd/debugnewvm
timed out.) Running it 3 more times, there was still one
TestVariousDeadlines failure and 2 successes, so we'll have
to keep watching it.

Updates golang/go#26945.

Change-Id: Ibd1e990e60c3a69a5fddede18d7a121fa319e79d
Reviewed-on: https://go-review.googlesource.com/130137
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 24, 2018

An update here. I've looked over the plan9-386 failures over the last 2 days:

Out of the 11 builds that failed, 5 were due to TestVariousDeadlines failing with the same "Hangup" errors. It seems this flakiness issue isn't completely resolved yet.
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 5, 2018

Change https://golang.org/cl/152721 mentions this issue: net: skip TestVariousDeadlines on Plan 9
gopherbot pushed a commit that referenced this issue Dec 5, 2018
@0intro @bradfitz
net: skip TestVariousDeadlines on Plan 9
09f5411 
This test is regularly failing on the plan9/386
builder running on GCE, but we haven't figured
out the issue yet.

Updates #26945.

Change-Id: I8cbe0df43c0757e7bc68e370311f4a28cd7b049b
Reviewed-on: https://go-review.googlesource.com/c/152721
Run-TryBot: David du Colombier <0intro@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

@0intro 0intro

Labels
Builders OS-Plan9
Projects
None yet
Milestone
Unplanned
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@dmitshur @0intro @gopherbot
You can’t perform that action at this time.