Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: mirror the "dl" repo to GitHub #26949

Closed
dmitshur opened this issue Aug 12, 2018 · 11 comments

Comments

Projects
None yet
5 participants
@dmitshur
Copy link
Member

commented Aug 12, 2018

Issue #23223 has resulted in the creation of a new repository:

https://go.googlesource.com/dl

That new repository is currently not mirrored to GitHub, hence this is 404:

https://github.com/golang/dl (404)

Is that the result of a conscious decision? Or has the decision not been made yet, and this is a potential follow-up task? /cc @bradfitz @andybons

@dmitshur dmitshur changed the title dl: to be, or not to be cloned to GitHub? dl: to be, or not to be mirrored to GitHub? Aug 13, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

There's just little reason to put it on GitHub as it's auto-generated. I don't expect any PRs to it.

@agnivade

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

If it's not an issue, I think its good to mirror it on github to be consistent with other repos. I wanted to take a look at the code one day and was surprised to not find it in github.

#26810 may be one such issue where a PR can be expected.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2018

I'm amused about "It doesn't need to be on GitHub since there won't be any PRs" since until a few months ago all our repos were on GitHub and none of them accepted PRs. :-P

@bradfitz

This comment has been minimized.

Copy link
Member

commented Aug 18, 2018

My argument was two sentences that were mostly unrelated, but I guess that wasn't obvious.

  • There's just little reason to put it on GitHub as it's auto-generated.
  • I don't expect any PRs to it.

Bullet 1 is just the code is boring. We can publish boring code, though. Much of it already is. And probably better to not have any snowflake repos.

@dmitshur

This comment has been minimized.

Copy link
Member Author

commented Aug 19, 2018

I agree with Brad's arguments, the value added is not very high. However, I think we should do it, for the following 2 reasons:

  • Consistency and simplicity. "And probably better to not have any snowflake repos." Exactly. All other Go repos are mirrored, there's no good reason why this one shouldn't be. It's simpler just to mirror all. People won't run into the unexpected situation where one repo isn't mirrored and wonder why.
  • It's a good chance for me to practice and learn how to do this. I'm sure we'll have some new repo in the future that we will actively want to mirror, and it'd be great if I can help with doing that.

@bradfitz bradfitz added the NeedsFix label Aug 19, 2018

@bradfitz bradfitz changed the title dl: to be, or not to be mirrored to GitHub? x/build: mirror the "dl" repo to GitHub Aug 19, 2018

@gopherbot gopherbot added this to the Unreleased milestone Aug 19, 2018

@bradfitz

This comment has been minimized.

Copy link
Member

commented Aug 19, 2018

All yours.

@gopherbot

This comment has been minimized.

Copy link

commented Sep 6, 2018

Change https://golang.org/cl/133896 mentions this issue: maintner/maintnerd, cmd/gerritbot, cmd/gitmirror: add golang/dl to whitelist

gopherbot pushed a commit to golang/build that referenced this issue Sep 7, 2018

maintner/maintnerd, cmd/gerritbot, cmd/gitmirror: add golang/dl to wh…
…itelist

In golang/go#23223, we've created a new subrepository:

	https://go.googlesource.com/dl

Unlike other subrepositories, there isn't a mirror on GitHub yet:

	https://github.com/golang/dl (404 at this moment)

We want to include it in the whitelist for mirroring to GitHub,
including mirroring its pull requests to Gerrit. The motivation is to
make this subrepository consistent with all others and prevent people
from running into an unexpected situation when some repos are mirrored
but some aren't.

We don't actually expect much contribution activity to the dl subrepo,
because it's very narrow in scope and mostly generated code.

Updates golang/go#26949.

Change-Id: Id995bb3d97b8eb328e6c6bba6714bc74fbefb942
Reviewed-on: https://go-review.googlesource.com/133896
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@gopherbot

This comment has been minimized.

Copy link

commented Sep 7, 2018

Change https://golang.org/cl/134117 mentions this issue: remove blank line from codereview.cfg

@dmitshur

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2018

With CL 133896 merged, all relevant components redeployed, and some additional steps taken (to be documented), this is done. Mirroring the dl repo to GitHub, and its PRs back to Gerrit now works.

The last thing to confirm after this is that googlebot will apply the "cla: yes"/"cla: no" labels on future PRs.

@dmitshur

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2018

The last thing to confirm after this is that googlebot will apply the "cla: yes"/"cla: no" labels on future PRs.

Verified that it works well in golang/dl#2:

image

@dmitshur

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2018

It seems that getting TryBots to be functional on the new repo would require additional steps that haven't been done yet. When I tried to run them in CL 134435, they failed with build logs like:

Sample Build Log
  builder: freebsd-amd64-11_1
      rev: 0f72e79856d246af85c449f9e5a357ba751cd234
 buildlet: http://10.240.0.6 GCE VM: buildlet-freebsd-11-1-rnf51e491
  started: 2018-09-11 03:10:10.630868346 +0000 UTC m=+373528.120239996
    ended: 2018-09-11 03:10:47.275209722 +0000 UTC m=+373564.764581353
  success: false

Events:
  2018-09-11T03:10:10Z checking_for_snapshot 
  2018-09-11T03:10:11Z finish_checking_for_snapshot after 14.1ms
  2018-09-11T03:10:11Z get_buildlet 
  2018-09-11T03:10:11Z awaiting_gce_quota 
  2018-09-11T03:10:11Z finish_awaiting_gce_quota after 0s
  2018-09-11T03:10:11Z create_gce_buildlet buildlet-freebsd-11-1-rnf51e491
  2018-09-11T03:10:11Z create_gce_instance buildlet-freebsd-11-1-rnf51e491
  2018-09-11T03:10:19Z finish_create_gce_instance after 7.6s; buildlet-freebsd-11-1-rnf51e491
  2018-09-11T03:10:19Z wait_buildlet_start buildlet-freebsd-11-1-rnf51e491
  2018-09-11T03:10:19Z got_instance_info waiting_for_buildlet...
  2018-09-11T03:10:39Z finish_wait_buildlet_start after 20.3s; buildlet-freebsd-11-1-rnf51e491
  2018-09-11T03:10:39Z finish_create_gce_buildlet after 28.2s; buildlet-freebsd-11-1-rnf51e491
  2018-09-11T03:10:39Z finish_get_buildlet after 28.6s
  2018-09-11T03:10:39Z using_buildlet 10.240.0.6:80
  2018-09-11T03:10:39Z write_snapshot_tar 
  2018-09-11T03:10:46Z finish_write_snapshot_tar after 6.68s
  2018-09-11T03:10:46Z make_and_test 
  2018-09-11T03:10:46Z fetching_subrepo dl
  2018-09-11T03:10:46Z get_source 
  2018-09-11T03:10:46Z finish_get_source after 0s
  2018-09-11T03:10:46Z get_source 
  2018-09-11T03:10:47Z finish_get_source after 0s
  2018-09-11T03:10:47Z finish_make_and_test after 546.7ms; err=runTests: 400 Bad Request; body: tar file entry env/crosscompile/linux-armel-stretch/Makefile contained unsupported file type Lrwxrwxrwx


Build log:
freebsd-amd64-11_1 at 0f72e79856d246af85c449f9e5a357ba751cd234 building dl at 1b784bc62cf67df416f5c76f71ac838defe1d9ef



Error: runTests: 400 Bad Request; body: tar file entry env/crosscompile/linux-armel-stretch/Makefile contained unsupported file type Lrwxrwxrwx

Not planning to spend time on this now; just making notes for future reference.

gopherbot pushed a commit to golang/dl that referenced this issue Sep 11, 2018

dl: delete blank line from codereview.cfg
It's not needed. It's not there in other subrepos:

- https://github.com/golang/image/blob/c73c2afc3b812cdd6385de5a50616511c4a3d458/codereview.cfg
- https://github.com/golang/net/blob/161cd47e91fd58ac17490ef4d742dc98bb4cf60e/codereview.cfg

Using this to test PRs for golang/go#26949.

Change-Id: I7152ea2dae1a511928e787598696274cf2b315f9
GitHub-Last-Rev: 51dbb14
GitHub-Pull-Request: #1
Reviewed-on: https://go-review.googlesource.com/134117
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.