Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website/internal/dl: go-import meta tag isn't served for golang.org/dl/internal/{version,genv} #26965

Open
dmitshur opened this issue Aug 13, 2018 · 2 comments
Labels
Milestone

Comments

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Aug 13, 2018

https://golang.org/dl/internal/version?go-get=1 is 404.

It should be serving something similar to https://golang.org/x/tools/go/vcs?go-get=1, etc.

$ export GOPATH=/tmp/empty
$ go get golang.org/dl/internal/version
package golang.org/dl/internal/version: unrecognized import path "golang.org/dl/internal/version" (parse https://golang.org/dl/internal/version?go-get=1: no go-import meta tags ())

$ goexec 'vcs.RepoRootForImportPath("golang.org/dl/internal/version", false)'
(*vcs.RepoRoot)(nil)
(*errors.errorString)(&errors.errorString{
	s: (string)("unrecognized import path \"golang.org/dl/internal/version\""),
})

This causes https://godoc.org/golang.org/dl/internal/version to show not found, etc.

This affects golang.org/dl/internal/genv package too.

@dmitshur dmitshur changed the title dl/internal/version: go-import meta tag isn't served godoc/dl: go-import meta tag isn't served for golang.org/dl/internal/{version,genv} Aug 13, 2018
@dmitshur dmitshur added the Builders label Aug 13, 2018
@andybons andybons added the NeedsFix label Aug 13, 2018
@andybons andybons added this to the Unreleased milestone Aug 13, 2018
@dmitshur dmitshur removed the Builders label Aug 13, 2018
@bradfitz

This comment has been minimized.

Copy link
Contributor

@bradfitz bradfitz commented Aug 13, 2018

True, but kinda low priority, no? This only affects people trying to go get those internal packages directly, rather than go-getting the actual go1.N.M commands?

@dmitshur

This comment has been minimized.

Copy link
Member Author

@dmitshur dmitshur commented Aug 13, 2018

Yes, this is a very minor issue. Anyone just doing go get golang.org/dl/gox.y.z isn't affected. I just filed it because I ran into it (couldn't read the package's source code/docs).

@dmitshur dmitshur changed the title godoc/dl: go-import meta tag isn't served for golang.org/dl/internal/{version,genv} x/website/internal/dl: go-import meta tag isn't served for golang.org/dl/internal/{version,genv} Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.