Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cgo: incorrect line numbers #2697

Closed
bradfitz opened this issue Jan 13, 2012 · 7 comments

Comments

@bradfitz
Copy link
Member

commented Jan 13, 2012

The line numbers reported by error messages when cgo involved are wrong.

Repro:

* get https://github.com/mattn/go-sqlite3
* add a dummy field to the SQLiteStmt struct.
* build

See error message like:

sqlite3.go:111[/tmp/go-build484757470/github.com/mattn/go-sqlite3/_obj/sqlite3.cgo1.go:114]:
too few values in struct initializer

... and witness that 114 (or whatever) isn't actually where the struct initializer is.



ante:go $ hg log | head
changeset:   11230:52099988ec3a
tag:         tip
user:        Brad Fitzpatrick <bradfitz@golang.org>
date:        Fri Jan 13 11:48:57 2012 -0800
@bradfitz

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2012

Comment 1:

(or line 111, btw.  it was actually on line 134)
@robpike

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2012

Comment 2:

Labels changed: added priority-go1, removed priority-triage.

@robpike

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2012

Comment 3:

Status changed to Accepted.

@robpike

This comment has been minimized.

Copy link
Contributor

commented Jan 13, 2012

Comment 4:

Owner changed to builder@golang.org.

@alberts

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2012

Comment 5:

see also issue #1047
@gopherbot

This comment has been minimized.

Copy link

commented Jan 28, 2012

Comment 7 by monnand:

I have fixed this bug. The patch is commited and ready to be reviewed:
http://golang.org/cl/5569084/
@griesemer

This comment has been minimized.

Copy link
Contributor

commented Feb 10, 2012

Comment 8:

This issue was closed by revision f8cf82f.

Status changed to Fixed.

@bradfitz bradfitz added fixed labels Feb 10, 2012

@rsc rsc added this to the Go1 milestone Apr 10, 2015

@rsc rsc removed the priority-go1 label Apr 10, 2015

@golang golang locked and limited conversation to collaborators Jun 24, 2016

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.