Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upencoding/json, encoding/xml: update documentation to use embedded fields instead of anonymous fields. #27031
Labels
Comments
agnivade
changed the title
|
I can make this commit and pull request. Thanks. |
moficodes
added a commit
to moficodes/go
that referenced
this issue
Aug 18, 2018
Json marshal documentation refers to "anonymous struct fields" which has been renamed to "embedded struct fields" changed doc to reflect that change Changes to be committed: modified: src/encoding/json/encode.go modified: src/encoding/xml/marshal.go modified: src/encoding/xml/read.go Fixes golang#27031
|
Change https://golang.org/cl/129815 mentions this issue: |
|
Change https://golang.org/cl/129756 mentions this issue: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a documentation issue.
The json.Marshal documentation refers to "anonymous struct fields," which the spec has been calling "embedded" struct fields since f8b4123. This is confusing to readers who want to know how embedded struct fields are marshaled and aren't aware of the historic terminology.
Searching the codebase for "anonymous struct" suggests that the encoding/xml godoc has the same issue.