Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: modfetch TestCodeRepo test fails #27042

Closed
ALTree opened this issue Aug 16, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@ALTree
Copy link
Member

commented Aug 16, 2018

$ gotip version
go version devel +dea36a6f75 Thu Aug 16 18:27:09 2018 +0000 linux/amd64
$ cd go/src/cmd/go/internal/modfetch

$ gotip test -run=TestCodeRepo/swtch.com_testmod
go: finding swtch.com/testmod v1.0.0
--- FAIL: TestCodeRepo (0.50s)
    --- FAIL: TestCodeRepo/swtch.com_testmod/v1.0.0 (0.50s)
        coderepo_test.go:372: info.Name = "", want "v1.0.0"
        coderepo_test.go:375: info.Short = "", want "v1.0.0"
FAIL
exit status 1
FAIL	cmd/go/internal/modfetch	0.556s

The failure also shows up on the longtest builder:
https://build.golang.org/log/323efedfa71344f4842b1965240875d16c199d50
but not on the others, since these tests are not run on -short.

@ALTree ALTree added this to the Go1.11 milestone Aug 16, 2018

@ALTree

This comment has been minimized.

Copy link
Member Author

commented Aug 17, 2018

Test failure bisected to CL 128355 (cmd/go: add go mod download).

@gopherbot

This comment has been minimized.

Copy link

commented Aug 17, 2018

Change https://golang.org/cl/129684 mentions this issue: cmd/go/internal/modfetch: correct TestCodeRepo expectation

@gopherbot gopherbot closed this in 16a7212 Aug 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.