Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: enable windows/arm before Go 1.14 release #27103

Closed
bradfitz opened this issue Aug 20, 2018 · 3 comments
Closed

cmd/vet: enable windows/arm before Go 1.14 release #27103

bradfitz opened this issue Aug 20, 2018 · 3 comments
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Aug 20, 2018

Reminder bug to re-enable windows/arm in cmd/vet/all before releasing Go 1.12.

(windows/arm is #26148)

/cc @jordanrh1

@bradfitz bradfitz added this to the Go1.12 milestone Aug 20, 2018
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 20, 2018

Change https://golang.org/cl/130055 mentions this issue: cmd/vet: exclude windows/arm from cmd/vet

gopherbot pushed a commit that referenced this issue Aug 20, 2018
Updates #27103

Change-Id: I1f7d198879e5912661e4156a86e13de2698a5473
Reviewed-on: https://go-review.googlesource.com/130055
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019
@agnivade agnivade changed the title cmd/vet: enable windows/arm before Go 1.12 release cmd/vet: enable windows/arm before Go 1.13 release Feb 28, 2019
@bradfitz
Copy link
Contributor Author

@bradfitz bradfitz commented Apr 29, 2019

@jordanrh1, what's the status of the windows/arm port and this bug?

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@agnivade agnivade changed the title cmd/vet: enable windows/arm before Go 1.13 release cmd/vet: enable windows/arm before Go 1.14 release Aug 11, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@ALTree
Copy link
Member

@ALTree ALTree commented Jul 22, 2020

This issue was opened as a reminder to remove some temporary code from cmd/vet/all/main.go, but that file no longer exists (vet is now run as part of go test); moreover the windows/arm port is currently inactive, so I think it's safe to close this issue.

@ALTree ALTree closed this Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.