Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: Fannkuch benchmark performance regression #27108

kklobe opened this issue Aug 21, 2018 · 5 comments

cmd/compile: Fannkuch benchmark performance regression #27108

kklobe opened this issue Aug 21, 2018 · 5 comments


Copy link

@kklobe kklobe commented Aug 21, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.11rc1 darwin/amd64

Does this issue reproduce with the latest release?


What operating system and processor architecture are you using (go env)?

macOS 10.13.6 (darwin/amd64)

What did you do?

tested the benchmark at:

using 1.10.3 and 1.11rc1 with:

time go run fannkuchredux.go 12
time go1.11rc1 run fannkuchredux.go 12

1.10.3: go run fannkuchredux.go 12 44.65s user 0.21s system 372% cpu 12.033 total
1.11rc1: go1.11rc1 run fannkuchredux.go 12 57.70s user 0.24s system 373% cpu 15.528 total

What did you expect to see?

1.11rc1 timings closer to 1.10.3

What did you see instead?

1.11rc1 timings slower than 1.10.3

@bradfitz bradfitz changed the title Fannkuch benchmark performance regression cmd/compile: Fannkuch benchmark performance regression Aug 22, 2018
Copy link

@bradfitz bradfitz commented Aug 22, 2018

Copy link

@TocarIP TocarIP commented Aug 23, 2018

Disabling branchelim seems to bring performance back to 1.10 level. Interestingly enough, on test/bench/go1/fannkuch disabling CMOV hurts performance by 20%

Copy link

@navytux navytux commented Aug 28, 2018

Possibly related issue about still unfixed Fannkuch11 performance regression from Go1.8 -> Go1.9 time: #18977.

For the reference: Fannkuch11 performance depends heavily on BCE: #24660.

Copy link

@TocarIP TocarIP commented Sep 24, 2018

I've looked at instruction-level profile and found that all conditional moves are out of the hot-spot. Main problem is that enabling branchelim pass caused different register allocation, which in turn put register spills/fills inside the inner loop.

Copy link

@randall77 randall77 commented Dec 12, 2018

Punting to 1.13, too late for anything major in 1.12.

@randall77 randall77 removed this from the Go1.12 milestone Dec 12, 2018
@randall77 randall77 added this to the Go1.13 milestone Dec 12, 2018
@andybons andybons removed this from the Go1.13 milestone Jul 8, 2019
@andybons andybons added this to the Go1.14 milestone Jul 8, 2019
@rsc rsc removed this from the Go1.14 milestone Oct 9, 2019
@rsc rsc added this to the Backlog milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants