Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: ConnectionState struct can not be json encoded in 1.11rc1 [1.11 backport] #27131

Closed
FiloSottile opened this issue Aug 21, 2018 · 2 comments
Closed

crypto/tls: ConnectionState struct can not be json encoded in 1.11rc1 [1.11 backport] #27131

FiloSottile opened this issue Aug 21, 2018 · 2 comments
Labels
CherryPickApproved FrozenDueToAge
Milestone
Go1.11

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Aug 21, 2018

This is a backport tracking issue for #27125
@FiloSottile FiloSottile added this to the Go1.11 milestone Aug 21, 2018
@gopherbot

This comment has been minimized.

Sign in to view
Copy link

@gopherbot gopherbot commented Aug 22, 2018

Change https://golang.org/cl/130655 mentions this issue: crypto/tls: make ConnectionState.ExportKeyingMaterial a method
gopherbot pushed a commit that referenced this issue Aug 22, 2018
@FiloSottile
[release-branch.go1.11] crypto/tls: make ConnectionState.ExportKeying…
Loading status checks…
2eb8116 
…Material a method

The unexported field is hidden from reflect based marshalers, which
would break otherwise. Also, make it return an error, as there are
multiple reasons it might fail.

Fixes #27131

Change-Id: I92adade2fe456103d2d5c0315629ca0256953764
Reviewed-on: https://go-review.googlesource.com/130535
Run-TryBot: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 240cb4c75fbe969364edb1a7f7ebd2d827831d34)
Reviewed-on: https://go-review.googlesource.com/130655
@FiloSottile

This comment has been minimized.

Sign in to view
Copy link
Member Author

@FiloSottile FiloSottile commented Aug 24, 2018

Fixed by 2eb8116
@golang golang locked and limited conversation to collaborators Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved FrozenDueToAge
Projects
None yet
Milestone
  Go1.11
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@FiloSottile @gopherbot
You can’t perform that action at this time.