cmd/compile: rename a bunch of things

[josharian]

Over time, I've noticed many things in the compiler that I'd like to rename, but I haven't because of the merge pain it causes and the review annoyance. I propose to use this issue to accumulate (and bikeshed) a list of renamings that we as a community want. Then a trusted contributor can do a single, automated bulk rename all in one commit.

I think this should happen shortly after the freeze starts. That gives everyone maximum opportunity to get all their CLs submitted. (Doing it early in the cycle is the worst idea, as it potentially breaks three months of private CL work.)

I'll start off the list with:

OPROC -> OGO

I'd also like new names for all of Etop, Erv, Etype, Ecall, Efnstruct, Easgn, and Ecomplit, but don't have good suggestions.

[randall77]

OCOM -> OCOMPLEMENT. I always parse the former as COMmunicate.
OMINUS -> ONEGATE. It's not symmetric with OPLUS anymore, but OPLUS is rare.
OIND -> ODEREF. I'd be happy with a better replacement, but OIND is weak.

There's a lot of stuff in the compiler that could be camel-cased instead of all lowercase.

I want to change the sense of kindNoPointers. That's a bit more than just a rename, so maybe that's a separate change.

[josharian]

As an experiment, further discussion to occur at https://docs.google.com/document/d/19_ExiylD9MRfeAjKIfEsMU1_RGhuxB9sA0b5Zv7byVI/.

[gopherbot]

Change https://golang.org/cl/150140 mentions this issue: cmd/compile: bulk rename

[josharian]

This bulk rename went reasonably smoothly for Go 1.12. Let's do it again (assuming we find things we want to rename). Let's use this issue as a scratch pad to jot down things we'd like to rename for Go 1.13, and then near the end of the cycle we'll use a google doc again to discuss and agree on new names.

[josharian]

mayAffectMemory -> mightAffectMemory? (permission vs epistemic uncertainty)

[gopherbot]

Change https://golang.org/cl/169157 mentions this issue: runtime: remove kindNoPointers