New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/dl: go get -u golang.org/dl/... finds two main functions #27262

Closed
elagergren-spideroak opened this Issue Aug 27, 2018 · 4 comments

Comments

Projects
None yet
5 participants
@elagergren-spideroak

elagergren-spideroak commented Aug 27, 2018

What did you do?

go get -u golang.org/dl/...

What did you see instead?

$ go get -u golang.org/dl/...
# golang.org/dl/go1.10
gopath/src/golang.org/dl/go1.10/main.go:22:6: main redeclared in this block
	previous declaration at gopath/src/golang.org/dl/go1.10/go1.10.go:22:6

https://go.googlesource.com/dl/+/master/go1.10/ indicates there's both a main.go and go1.10.go, both of which contain (nearly) the same content. No other dl/ packages have a go1.xx.go file.

@gopherbot gopherbot added this to the Unreleased milestone Aug 27, 2018

@dolmen

This comment has been minimized.

Show comment
Hide comment
@dolmen

dolmen Aug 27, 2018

@bradfitz In 1bf763e7e you added main.go, but go1.10.go was already there.

dolmen commented Aug 27, 2018

@bradfitz In 1bf763e7e you added main.go, but go1.10.go was already there.

@gopherbot

This comment has been minimized.

Show comment
Hide comment
@gopherbot

gopherbot Aug 27, 2018

Change https://golang.org/cl/131655 mentions this issue: go1.10: remove duplicate file go1.10.go

gopherbot commented Aug 27, 2018

Change https://golang.org/cl/131655 mentions this issue: go1.10: remove duplicate file go1.10.go

@agnivade

This comment has been minimized.

Show comment
Hide comment
@agnivade

agnivade Aug 27, 2018

Member

Looks like gopherbot doesn't close issues from dl repos. Closing it since CL has been merged.

Member

agnivade commented Aug 27, 2018

Looks like gopherbot doesn't close issues from dl repos. Closing it since CL has been merged.

@agnivade agnivade closed this Aug 27, 2018

gopherbot pushed a commit to golang/dl that referenced this issue Sep 7, 2018

go1.10: remove duplicate file go1.10.go
We use main.go everywhere else and I'd added an auto-generated main.go
here in CL 130977.

Fixes golang/go#27262

Change-Id: Ic9a76eb33315e922c2156c76fe4900e218d8787d
Reviewed-on: https://go-review.googlesource.com/131655
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Sep 7, 2018

Member

Looks like gopherbot doesn't close issues from dl repos.

For posterity, it does now, because #26949 is resolved.

Member

dmitshur commented Sep 7, 2018

Looks like gopherbot doesn't close issues from dl repos.

For posterity, it does now, because #26949 is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment