Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/go/ssa/interp: broken at tip #27292

Closed
bradfitz opened this issue Aug 28, 2018 · 6 comments
Closed

x/tools/go/ssa/interp: broken at tip #27292

bradfitz opened this issue Aug 28, 2018 · 6 comments
Assignees
Milestone

Comments

@bradfitz
Copy link
Contributor

@bradfitz bradfitz commented Aug 28, 2018

I'm going to disable these tests in short mode until they're made robust.

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 28, 2018

Change https://golang.org/cl/131717 mentions this issue: go/ssa/interp: disable regularly broken tests in short mode

gopherbot pushed a commit to golang/tools that referenced this issue Aug 28, 2018
Updates golang/go#27292

Change-Id: I845afc64ca9ed2065c3b5645b7ce6def290d7a6d
Reviewed-on: https://go-review.googlesource.com/131717
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bcmills
Copy link
Member

@bcmills bcmills commented Sep 25, 2018

We're trying out go test all as a general recommendation for testing in module mode.

Can we disable these in long mode too, or do we expect an easy fix soon?

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 25, 2018

Change https://golang.org/cl/137315 mentions this issue: go/ssa/interp: skip failing test

gopherbot pushed a commit to golang/tools that referenced this issue Sep 25, 2018
This test introduces noise when using 'go test all' or 'go test ./...'
to test go/packages and the tools that depend on it.

Since it has been broken for around a month, skip it indefinitely.

Updates golang/go#27292

Change-Id: I796292310332712e14bc8a0b73e36a8ed6f8a73f
Reviewed-on: https://go-review.googlesource.com/137315
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 12, 2018

Change https://golang.org/cl/153860 mentions this issue: [release-branch.go1.11] go/ssa/interp: skip failing test

@gopherbot
Copy link

@gopherbot gopherbot commented Dec 12, 2018

Change https://golang.org/cl/153861 mentions this issue: [release-branch.go1.11] go/ssa/interp: skip failing test

gopherbot pushed a commit to golang/tools that referenced this issue Dec 12, 2018
This test introduces noise when using 'go test all' or 'go test ./...'
to test go/packages and the tools that depend on it.

Since it has been broken for around a month, skip it indefinitely.

Updates golang/go#27292

Change-Id: Ia22f371bbf8f94bbb604327b3028d1259b65a91f
Reviewed-on: https://go-review.googlesource.com/137315
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/153861
Run-TryBot: Andrew Bonventre <andybons@golang.org>
@gopherbot
Copy link

@gopherbot gopherbot commented Mar 22, 2019

Change https://golang.org/cl/168898 mentions this issue: go/ssa/interp: make tests fast and robust

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.