Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
x/tools/cmd/godoc: some line-heights became less readable #27321
https://go-review.googlesource.com/c/tools/+/94935 changed some line-height values in godoc/static/style.css, dropping the em unit specifier.
It appears these line-height changes weren't meant to have any visible changes. The reasoning in the CL states:
But em is not the default unit for line-height (see https://developer.mozilla.org/en-US/docs/Web/CSS/line-height).
The computed line-height went from 20.8px to 18.2px.
I find the original em version to be more readable. Since it looks like this visible change was inadvertent, could we add the em units back to lines 5 and 15?
Right, there is indeed a difference. Good catch.
The MDN docs do recommend the line-height to be unitless however. https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#Prefer_unitless_numbers_for_line-height_values.
Perhaps, we can re-calculate the required line-height, and give a slightly higher number and still keep it unitless ?