Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: slow streaming with http2 due to MaxConcurrentStreams #27338

Closed
krasi-georgiev opened this issue Aug 29, 2018 · 3 comments
Closed

x/net/http2: slow streaming with http2 due to MaxConcurrentStreams #27338

krasi-georgiev opened this issue Aug 29, 2018 · 3 comments
Milestone

Comments

@krasi-georgiev
Copy link

@krasi-georgiev krasi-georgiev commented Aug 29, 2018

The k8s go client doesn't behave well since the change in golang/net@1c05540

What happens is that when the client hits the MaxConcurrentStreams of the server any updates after that take very long time (1-2 minutes) so on k8s clusters with constant changes the client can never catch up.
The fix in that commit seems valid, but shouldn't the retry interval can be configurable or provide an option to open a new connection like with the old behaviour.

More on the issue: kubernetes/client-go#456

go version go1.11 linux/amd64

@gopherbot gopherbot added this to the Unreleased milestone Aug 29, 2018
@krasi-georgiev krasi-georgiev changed the title x/net: slow streaming due to MaxConcurrentStreams x/net: slow streaming with http2 due to MaxConcurrentStreams Aug 29, 2018
@krasi-georgiev

This comment has been minimized.

Copy link
Author

@krasi-georgiev krasi-georgiev commented Aug 29, 2018

@krasi-georgiev

This comment has been minimized.

Copy link
Author

@krasi-georgiev krasi-georgiev commented Aug 29, 2018

I will try to make a reproducible test, but in the meanwhile some initial input would be useful.

@meirf

This comment has been minimized.

Copy link
Contributor

@meirf meirf commented Aug 29, 2018

This looks like a dup of #27044 so I'm closing, but tagging @bradfitz to take a look at 27044 due to the urgency that usually comes with k8s issues.

@meirf meirf closed this Aug 29, 2018
@mikioh mikioh changed the title x/net: slow streaming with http2 due to MaxConcurrentStreams x/net/http2: slow streaming with http2 due to MaxConcurrentStreams Feb 26, 2019
@golang golang locked and limited conversation to collaborators Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.