Skip to content

/ go

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: invalid pointer found on stack [1.11 backport] #27342

Closed
gopherbot opened this issue Aug 29, 2018 · 2 comments
Closed

runtime: invalid pointer found on stack [1.11 backport] #27342

gopherbot opened this issue Aug 29, 2018 · 2 comments
Labels
CherryPickApproved FrozenDueToAge
Milestone
Go1.11.1

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Aug 29, 2018 •
edited by heschik

@heschik requested issue #27278 to be considered for backport to the next 1.11 minor release.

@gopherbot please backport this fix for a serious compiler bug to 1.11.
@gopherbot gopherbot mentioned this issue Aug 29, 2018
Closed
@gopherbot gopherbot added this to the Go1.10.5 milestone Aug 29, 2018
@heschik heschik changed the title runtime: invalid pointer found on stack [1.10 backport] runtime: invalid pointer found on stack [1.11 backport] Aug 29, 2018
@heschik heschik modified the milestones: Go1.10.5, Go1.11.1 Aug 29, 2018
@nvanbenschoten nvanbenschoten mentioned this issue Sep 10, 2018
Closed
@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

@gopherbot gopherbot commented Sep 11, 2018

Change https://golang.org/cl/134615 mentions this issue: [release-branch.go1.11] cmd/compile: count nil check as use in dead auto elim
@gopherbot

This comment has been minimized.

Sign in to view
Copy link
Author

@gopherbot gopherbot commented Sep 11, 2018

Closed by merging 5a25f45 to release-branch.go1.11.
@gopherbot gopherbot closed this Sep 11, 2018
gopherbot pushed a commit that referenced this issue Sep 11, 2018
@cherrymui @andybons
[release-branch.go1.11] cmd/compile: count nil check as use in dead a…
5a25f45 
…uto elim

Nil check is special in that it has no use but we must keep it.
Count it as a use of the auto.

Fixes #27342.

Change-Id: I857c3d0db2ebdca1bc342b4993c0dac5c01e067f
Reviewed-on: https://go-review.googlesource.com/131955
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 54f9c04)
Reviewed-on: https://go-review.googlesource.com/134615
Run-TryBot: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
@golang golang locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved FrozenDueToAge
Projects
None yet
Milestone
  Go1.11.1
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@gopherbot @andybons @heschik
You can’t perform that action at this time.