Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
net: testSpliceReaderAtEOF closed connection: got err = splice: invalid argument #27355
When running tests against the new splice code in the net package from 1.11 the syscall appears to be returning an error on CentOS 6.
What version of Go are you using (
I'm currently investigating on CentOS 6, and I can reproduce the issue.
When I run the
I'll continue investigating.
Refactor TestSplice/readerAtEOF to handle cases where we disable splice on older kernels better. If splice is disabled, net.splice and poll.Splice do not get to observe EOF on the reader, because poll.Splice returns immediately with EINVAL. The test fails unexpectedly, because the splice operation is reported as not handled. This change refactors the test to handle the aforementioned case correctly, by not calling net.splice directly, but using a higher level check. Fixes #27355. Change-Id: I0d5606b4775213f2dbbb84ef82ddfc3bab662a31 Reviewed-on: https://go-review.googlesource.com/132096 Run-TryBot: Ian Lance Taylor <email@example.com> TryBot-Result: Gobot Gobot <firstname.lastname@example.org> Reviewed-by: Ian Lance Taylor <email@example.com> (cherry picked from commit bd49b3d) Reviewed-on: https://go-review.googlesource.com/132281 Reviewed-by: Andrew Bonventre <firstname.lastname@example.org>