New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: clean up open issue on closed milestones #27392

Open
FiloSottile opened this Issue Aug 30, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@FiloSottile
Member

FiloSottile commented Aug 30, 2018

Some of the closed milestones here have open issues. They shouldn't.

https://github.com/golang/go/milestones?state=closed

@FiloSottile FiloSottile added this to the Unreleased milestone Aug 30, 2018

@FiloSottile FiloSottile self-assigned this Aug 30, 2018

@agnivade

This comment has been minimized.

Show comment
Hide comment
@agnivade

agnivade Oct 2, 2018

Member

@FiloSottile - Related to this, there are also backport issues which keep getting pushed back to the next minor release milestone.

If we aren't going to backport a fix, shouldn't we just close the issue ? Is there a reason, a fix should not be in 1.11.1, but in 1.11.2 ?

Member

agnivade commented Oct 2, 2018

@FiloSottile - Related to this, there are also backport issues which keep getting pushed back to the next minor release milestone.

If we aren't going to backport a fix, shouldn't we just close the issue ? Is there a reason, a fix should not be in 1.11.1, but in 1.11.2 ?

@FiloSottile

This comment has been minimized.

Show comment
Hide comment
@FiloSottile

FiloSottile Oct 2, 2018

Member

@agnivade If we decided we are not backporting something, yes we should close the issue. But reasons to push to the next release include: the fix is not ready, the cherry-pick is not finished, and a decision wasn't made. Then the issue is useful to keep track of it.

There is a gap in the process in that we did not have a process to go through the open issues and make decisions for the ones that are ready. We'll address that soon.

Member

FiloSottile commented Oct 2, 2018

@agnivade If we decided we are not backporting something, yes we should close the issue. But reasons to push to the next release include: the fix is not ready, the cherry-pick is not finished, and a decision wasn't made. Then the issue is useful to keep track of it.

There is a gap in the process in that we did not have a process to go through the open issues and make decisions for the ones that are ready. We'll address that soon.

@dmitshur

This comment has been minimized.

Show comment
Hide comment
@dmitshur

dmitshur Oct 7, 2018

Member

@FiloSottile I just checked https://github.com/golang/go/milestones?state=closed, and I think the original issue is resolved by now. If there's nothing more to do here, we can close this.

(There was one open issue in the closed Go1.11 milestone, because it got reopened recently. I fixed it by moving it to Go1.12 milestone.)

Member

dmitshur commented Oct 7, 2018

@FiloSottile I just checked https://github.com/golang/go/milestones?state=closed, and I think the original issue is resolved by now. If there's nothing more to do here, we can close this.

(There was one open issue in the closed Go1.11 milestone, because it got reopened recently. I fixed it by moving it to Go1.12 milestone.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment