Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cgo: typedef pointer arguments regression [1.11 backport] #27395

Closed
gopherbot opened this Issue Aug 30, 2018 · 4 comments

Comments

Projects
None yet
6 participants
@gopherbot
Copy link

gopherbot commented Aug 30, 2018

@FiloSottile requested issue #27340 to be considered for backport to the next 1.11 minor release.

@gopherbot please file this to be considered for backport to 1.11 and 1.10. This is a regression.

@bradfitz

This comment has been minimized.

Copy link
Member

bradfitz commented Nov 1, 2018

Not fixed in master yet, so bumping to Go 1.11.3.

@randall77

This comment has been minimized.

Copy link
Contributor

randall77 commented Dec 14, 2018

I think it is worth backporting.

@gopherbot

This comment has been minimized.

Copy link
Author

gopherbot commented Dec 14, 2018

Change https://golang.org/cl/154277 mentions this issue: [release-branch.go1.11] cmd/cgo: preserve type information across loadDWARF loop

@gopherbot

This comment has been minimized.

Copy link
Author

gopherbot commented Dec 14, 2018

Closed by merging 928a4b6 to release-branch.go1.11.

@gopherbot gopherbot closed this Dec 14, 2018

gopherbot pushed a commit that referenced this issue Dec 14, 2018

[release-branch.go1.11] cmd/cgo: preserve type information across loa…
…dDWARF loop

CL 122575 and its successors introduced a loop calling loadDWARF,
whereas before we only called it once. Pass a single typeConv to each
call, rather than creating a new one in loadDWARF itself. Change the
maps from dwarf.Type to use string keys rather than dwarf.Type keys,
since when the DWARF is reloaded the dwarf.Type pointers will be
different. These changes permit typeConv.Type to return a consistent
value for a given DWARF type, avoiding spurious type conversion errors
due to typedefs loaded after the first loop iteration.

Updates #27340
Fixes #27395

Change-Id: Ic33467bbfca4c54e95909621b35ba2a58216d96e
Reviewed-on: https://go-review.googlesource.com/c/152762
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit 6d43587)
Reviewed-on: https://go-review.googlesource.com/c/154277
Run-TryBot: Filippo Valsorda <filippo@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.