Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: GOMIPS environment variable does not affect caching of mipsle code [1.10 backport] #27421

Closed
gopherbot opened this issue Aug 31, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@gopherbot
Copy link

commented Aug 31, 2018

@FiloSottile requested issue #27260 to be considered for backport to the next 1.10 minor release.

@gopherbot please file this issue for backport to 1.11 and 1.10 (GOMIPS and the cache were introduced in 1.10, so it might affect both, if not please close the 1.10 issue).

@ianlancetaylor had milestoned this for 1.11.1 and I don't see a cherry-pick, but it was closed by the master fix.

@gopherbot

This comment has been minimized.

Copy link
Author

commented Nov 1, 2018

Change https://golang.org/cl/146560 mentions this issue: [release-branch.go1.10] cmd/go: add GOMIPS value to build id for mipsle

@gopherbot

This comment has been minimized.

Copy link
Author

commented Nov 1, 2018

Closed by merging 15c6cc7 to release-branch.go1.10.

@gopherbot gopherbot closed this Nov 1, 2018

gopherbot pushed a commit that referenced this issue Nov 1, 2018

[release-branch.go1.10] cmd/go: add GOMIPS value to build id for mipsle
Strip a trailing "le" from the GOARCH value when calculating the GOxxx
environment variable that affects it.

Updates #27260
Fixes #27421

Change-Id: I081f30d5dc19281901551823f4f56be028b5f71a
Reviewed-on: https://go-review.googlesource.com/131379
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 61318d7)
Reviewed-on: https://go-review.googlesource.com/c/146560
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.