Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: 'go test -coverprofile' emits slash-separated paths on Windows #27486

Closed
bcmills opened this issue Sep 4, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@bcmills
Copy link
Member

commented Sep 4, 2018

In microsoft/vscode-go#1847 (comment), @ramya-rao-a notes that in Go 1.11, go test -coverprofile on Windows changed to emit slash-separated paths instead of using the OS-local separator.

She has a workaround in vscode (where the regression was detected), but there may be other tools currently broken on Windows.

@bcmills bcmills added this to the Go1.12 milestone Sep 4, 2018

@bcmills

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2018

@gopherbot, please backport to 1.11: this appears to be a regression from 1.9 or 1.10.

@gopherbot

This comment has been minimized.

Copy link

commented Sep 4, 2018

Backport issue(s) opened: #27487 (for 1.11), #27488 (for 1.10).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://golang.org/wiki/MinorReleases.

@bcmills

This comment has been minimized.

Copy link
Member Author

commented Oct 24, 2018

@rsc says that the paths are intentionally (now) supposed to be the import path + filename, since the file may be in the module cache rather than the local filesystem.

Since @ramya-rao-a has updated the VSCode support to accept the new format and nobody else seems to have noticed, let's leave this as-is.

@bcmills bcmills closed this Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.