Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: ignore versions after hard punctuation in backport requests #27489

Open
bcmills opened this Issue Sep 4, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@bcmills
Copy link
Member

bcmills commented Sep 4, 2018

In #27486 (comment), I attempted to set up a backport issue for Go 1.11. However, apparently because I mentioned “from 1.9 or 1.10” in the justification, gopherbot constructed a backport issue for 1.10 too.

I think we should make gopherbot ignore versions that are separated from the first version in the comment by any punctuation other than a comma. (However, we should be careful not to stop after a period that appears as part of a version string.)

So, for example:
@gopherbot, p—— backport to Go 1.11: this is a regression from 1.9. should backport to 1.11 only.
@gopherbot, p—— backport to Go 1.11, and possibly 1.10: this is a bad runtime bug. should backport to both 1.11, 1.10.

(CC @FiloSottile )

@gopherbot gopherbot added this to the Unreleased milestone Sep 4, 2018

@gopherbot gopherbot added the Builders label Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.