Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/maintner: panic nil Timestamp for issue creation #27493

Closed
broady opened this issue Sep 4, 2018 · 1 comment
Closed

x/build/maintner: panic nil Timestamp for issue creation #27493

broady opened this issue Sep 4, 2018 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone

Comments

@broady
Copy link
Member

broady commented Sep 4, 2018

Running a copy of maintnerd, this happens on the client:

panic: timestamp: nil Timestamp

goroutine 25 [running]:
golang.org/x/build/maintner.(*Corpus).processGithubIssueMutation(0xb7a6e0, 0xc42476e160)
        /usr/local/google/home/cbro/src/golang.org/x/build/maintner/github.go:1186 +0x1b19
golang.org/x/build/maintner.(*Corpus).processMutationLocked(0xb7a6e0, 0xc42b9c8c00)
        /usr/local/google/home/cbro/src/golang.org/x/build/maintner/maintner.go:351 +0xaf
golang.org/x/build/maintner.(*Corpus).update(0xb7a6e0, 0x9383c0, 0xc4200be010, 0x936960, 0xb97fd0, 0x0, 0x0)
        /usr/local/google/home/cbro/src/golang.org/x/build/maintner/maintner.go:322 +0x152
golang.org/x/build/maintner.(*Corpus).UpdateWithLocker(0xb7a6e0, 0x9383c0, 0xc4200be010, 0x936960, 0xb97fd0, 0x0, 0x0)
        /usr/local/google/home/cbro/src/golang.org/x/build/maintner/maintner.go:280 +0xcf
main.main.func1(0x9383c0, 0xc4200be010)

It looks like restarting the process (ie, re-processing the mutations) works around this.

It looks like it's the timestamp for issue creation:
https://github.com/golang/build/blob/e7a2a012f38a99c659a95fa79309f521fe769cee/maintner/github.go#L1183-L1187

I'll look into this more.

@gopherbot gopherbot added this to the Unreleased milestone Sep 4, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Sep 4, 2018
@broady broady changed the title x/build/maintner: panic nil Timestamp x/build/maintner: panic nil Timestamp for issue creation Sep 4, 2018
@broady
Copy link
Member Author

broady commented Sep 4, 2018

Well, deleting the disk log and re-running didn't do anything.

@broady broady closed this as completed Sep 4, 2018
@golang golang locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

2 participants