Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: some facts are missing after an error [1.11 backport] #27497

Closed
gopherbot opened this issue Sep 4, 2018 · 2 comments
Closed

go/types: some facts are missing after an error [1.11 backport] #27497

gopherbot opened this issue Sep 4, 2018 · 2 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone

Comments

@gopherbot
Copy link
Contributor

@stamblerre requested issue #22467 to be considered for backport to the next 1.11 minor release.

@gopherbot please consider this for backport to 1.11, it fixes a minor bug.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 4, 2018
@gopherbot gopherbot added this to the Go1.11.1 milestone Sep 4, 2018
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/133395 mentions this issue: [release-branch.go1.11] go/types: handle nil pointer when panic is written outside of a function

@gopherbot
Copy link
Contributor Author

Closed by merging 0541668 to release-branch.go1.11.

gopherbot pushed a commit that referenced this issue Sep 12, 2018
…itten outside of a function

The current implementation crashes when someone writes a panic outside of
a function, which makes sense since that is broken code. This fix allows
one to type-check broken code.

Fixes #27497

Change-Id: I81b90dbd918162a20c60a821340898eaf02e648d
Reviewed-on: https://go-review.googlesource.com/132235
Reviewed-by: Alan Donovan <adonovan@google.com>
(cherry picked from commit c99687f)
Reviewed-on: https://go-review.googlesource.com/133395
Reviewed-by: Robert Griesemer <gri@golang.org>
@golang golang locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

1 participant