Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
x/build/cmd/gerritbot: comments occasionally not posted to GitHub PR #27504
Over the past couple of days I've been involved with at least two separate issues with bodies that were updated on Github but Gopherbot did not mirror them on Gerrit yet posted up messages on Gerrit.
Those issues are:
and also there have been a couple of PRs for which a Gerrit CL wasn't opened, perhaps the problem is related? For example:
The first two issues are behaving as expected. The Gerrit commit message is determined by the title and description of the PR and is one-way (GitHub -> Gerrit).
This isn’t correct. The Gerrit CLs were created by GerritBot, but no comment was added to the original GitHub PR.
changed the title from
x/build/cmd/gopherbot: some PR code revisions are not mirrored to Gerrit
x/build/cmd/gerritbot: comments occasionally not posted to GitHub PR
Sep 5, 2018
referenced this issue
Sep 7, 2018
Something along these lines happened in golang/dl#1 as well. The PR was mirrored (to https://go-review.googlesource.com/c/dl/+/134117) but no corresponding "PR has been imported to Gerrit" comment was created.
I filed #27561 with more details for that particular instance, but I suspect there's overlap with this issue.
pushed a commit
Sep 10, 2018
Another issue that might have played a role in this issue happening was #27536: gerritbot was crashing occasionally. It's conceivable (and likely) that each time it crashed, it missed some operations that should've been performed.
The crashing issue is resolved now, so I'm interested in hearing of any further re-occurrences of the original issue if it happens again.