Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upruntime: timeouts in os/signal tests [1.11 backport] #27521
Closed
Milestone
Comments
This comment has been minimized.
This comment has been minimized.
|
Change https://golang.org/cl/134096 mentions this issue: |
This comment has been minimized.
This comment has been minimized.
|
Closed by merging 5753489 to release-branch.go1.11. |
gopherbot
pushed a commit
that referenced
this issue
Sep 7, 2018
… far from timeout When pthread_cond_timedwait_relative_np gets a spurious wakeup (due to a signal, typically), we used to retry with the same relative timeout. That's incorrect, we should lower the timeout by the time we've spent in this function so far. In the worst case, signals come in and cause spurious wakeups faster than the timeout, causing semasleep to never time out. Also fix nacl and netbsd while we're here. They have similar issues. Fixes #27521 Change-Id: I6601e120e44a4b8ef436eef75a1e7c8cf1d39e39 Reviewed-on: https://go-review.googlesource.com/133655 Run-TryBot: Keith Randall <khr@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org> (cherry picked from commit 2bf1370f4369d75f4fffffc6fc05722bce13481b) Reviewed-on: https://go-review.googlesource.com/134096
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
@randall77 requested issue #27520 to be considered for backport to the next 1.11 minor release.