Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: vgo repository has stale snapshot - update, or indicate it is stale in README #27530

Closed
thepudds opened this issue Sep 6, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@thepudds
Copy link

commented Sep 6, 2018

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

vgo:

$ vgo version
go version go1.11 windows/amd64 vgo:devel +1b870077c8

What did you expect to see?

vgo tracking go releases, as described here:

https://groups.google.com/d/msg/golang-dev/BizWQk-hfw4/JdhnnJdJDAAJ

The main repo is now the source of truth for Go module support.
The vgo repo is now auto-generated from the main repo by running update.bash.

The vgo command is meant to allow Go 1.10 users to try modules.
It should behave exactly the same as the Go 1.11 go command,
except that GO111MODULE defaults to on (not auto), and it does
not run 'go vet' during 'go test' when using a Go 1.10 GOROOT.

We intend to run update.bash at each release milestone, but we missed
last week's update for go1.11beta3. I'll send that out shortly, along with
an update to the README.md.

I expect that vgo will continue to be updated alongside point releases of Go 1.11,
to continue to allow Go 1.10 users to try modules as they exist in Go 1.11.

What did you see instead?

Latest vgo commit:
cmd/go: import from main repo at go1.11beta3

$ go get -u golang.org/x/vgo

# 'go mod fix' still present in vgo, other newer commands missing:
$ vgo help mod
...
The commands are:

        edit        edit go.mod from tools or scripts
        fix         make go.mod semantically consistent
        graph       print module requirement graph
        init        initialize new module in current directory
        tidy        add missing and remove unused modules
        vendor      make vendored copy of dependencies
        verify      verify dependencies have expected content

Ideally vgo would be updated to align with the official 1.11 release. If not, ideally the README would be updated to indicate people should not use it for now. Beta3 had some significant issues.

@myitcv myitcv added the modules label Sep 6, 2018

@myitcv

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

@bcmills bcmills self-assigned this Sep 6, 2018

@bcmills bcmills added this to the Unreleased milestone Sep 6, 2018

@gopherbot

This comment has been minimized.

Copy link

commented Sep 10, 2018

Change https://golang.org/cl/134415 mentions this issue: cmd/go: import from main repo at go1.11

@bcmills

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

Ideally vgo would be updated to align with the official 1.11 release.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.