Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vgo: delete repo in March 2019 (1 month after Go 1.12) #27563

Open
davecheney opened this issue Sep 8, 2018 · 4 comments
Open

x/vgo: delete repo in March 2019 (1 month after Go 1.12) #27563

davecheney opened this issue Sep 8, 2018 · 4 comments
Labels
Milestone

Comments

@davecheney
Copy link
Contributor

@davecheney davecheney commented Sep 8, 2018

Since Go 1.11 was released several issues related to mixing vgo and go 1.11 have been logged, eg, #27562

I propose that vgo should be changed to work only with versions of Go in the range [1.10.3,1.11)

@gopherbot gopherbot added this to the Proposal milestone Sep 8, 2018
@bcmills bcmills changed the title Proposal: disable vgo for Go 1.11 and above Proposal: x/vgo: disable standalone 'vgo' binary for Go 1.11 and above Sep 10, 2018
@rsc
Copy link
Contributor

@rsc rsc commented Sep 19, 2018

We did intend for vgo to remain a kind of "preview of next cmd/go" if needed. I don't know that we really want to cut off 1.11. Especially since vgo right now is basically exactly "the go 1.11 cmd/go".

Loading

@rsc
Copy link
Contributor

@rsc rsc commented Oct 3, 2018

/cc @bcmills for thoughts

Loading

@rsc
Copy link
Contributor

@rsc rsc commented Oct 11, 2018

Talked with @bcmills. Plan is that vgo will stay as it is. There is benefit to letting vgo work with both 1.10 and 1.11, so that it's OK to use vgo and update to 1.11 without changing all the mentions of vgo. But moving on, vgo will not be updated. Once Go 1.12 is out, Go 1.10 will be deprecated, at which point all supported versions of Go will have module support. Then we can remove vgo entirely (maybe a month or so after the Go 1.12 release).

Loading

@rsc rsc changed the title Proposal: x/vgo: disable standalone 'vgo' binary for Go 1.11 and above x/vgo: delete repo in March 2019 (1 month after Go 1.12) Oct 11, 2018
@rsc rsc removed this from the Proposal milestone Oct 11, 2018
@rsc rsc added this to the Go1.13 milestone Oct 11, 2018
@agnivade
Copy link
Contributor

@agnivade agnivade commented Apr 9, 2019

@bcmills - A CL which removes all code will still keep the repo. I guess it will be better for someone with admin permissions to remove the the git repo altogether at https://go.googlesource.com/vgo/.

Loading

@andybons andybons removed this from the Go1.13 milestone Jul 8, 2019
@andybons andybons added this to the Go1.14 milestone Jul 8, 2019
@rsc rsc removed this from the Go1.14 milestone Oct 9, 2019
@rsc rsc added this to the Backlog milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants